From owner-cvs-src@FreeBSD.ORG  Fri Nov 18 18:03:08 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 76A8A16A420
	for <cvs-src@freebsd.org>; Fri, 18 Nov 2005 18:03:08 +0000 (GMT)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: from nproxy.gmail.com (nproxy.gmail.com [64.233.182.198])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4D69F43D73
	for <cvs-src@freebsd.org>; Fri, 18 Nov 2005 18:03:06 +0000 (GMT)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: by nproxy.gmail.com with SMTP id c2so1522nfe
	for <cvs-src@freebsd.org>; Fri, 18 Nov 2005 10:03:04 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=R7z04eMHa36ORtycVWpcjzQ9qYIoAU/aklK+/ophoDc8QNQlEQ2OB0g4l3qsQU+n6j2q17S9wb4J3mJlSPZFQESqhZyW9OScKxfVhZel38OKOYn3EZdl9peVVxMlsrSlyRDNW3OrE5lej9KWX7iMCuwFOAMOH0sC7iAjQl8KuEs=
Received: by 10.48.238.19 with SMTP id l19mr10882nfh;
	Fri, 18 Nov 2005 10:03:04 -0800 (PST)
Received: by 10.48.161.15 with HTTP; Fri, 18 Nov 2005 10:03:04 -0800 (PST)
Message-ID: <bb4a86c70511181003y5a8d404bnf4cb0a68c6d4ed24@mail.gmail.com>
Date: Fri, 18 Nov 2005 10:03:04 -0800
From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
To: Yar Tikhiy <yar@freebsd.org>
In-Reply-To: <20051118101729.GA87399@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200511152036.jAFKaQMZ089811@repoman.freebsd.org>
	<20051118101729.GA87399@freefall.freebsd.org>
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/etc/rc.d hcsecd sdpd
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2005 18:03:08 -0000

Yar,

> > emax        2005-11-15 20:36:26 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     etc/rc.d             hcsecd sdpd
> >   Log:
> >   Revise hcsecd(8) and sdpd(8) rc.d scripts.
> >
> >   - Have both scripts automatically kldload ng_btsocket(4). I did not w=
ant to
> >     do it, but its easier for users and it seems other scripts do simil=
ar things;
>
> You need not override the start method for such a hack.
> Just put the kldload in the prestart method.

actually, i had to. i have defined sdpd_group and sdpd_user variables,
and, by default, run_rc_command() checks if ${name}_group and
${name}_user are defined and uses su(1) to start ${command}.

i guess, i could have used prestart and undefine  sdpd_group and
sdpd_user before calling run_rc_command().

> In addition, you could check if the module is loaded already.
> See the pf* scripts for an example.

well, yes, i could. but a saw a couple of bad examples in /etc/rc.d :)
that do it without checking. if it really bugs people, i could fix
this.

thanks,
max