From owner-svn-src-all@FreeBSD.ORG Tue Jun 21 16:40:11 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBCC61065672; Tue, 21 Jun 2011 16:40:11 +0000 (UTC) (envelope-from guy.helmer@palisadesystems.com) Received: from ps-2-a.compliancesafe.com (ps-2-a.compliancesafe.com [216.81.161.163]) by mx1.freebsd.org (Postfix) with ESMTP id 76D5F8FC0A; Tue, 21 Jun 2011 16:40:11 +0000 (UTC) Received: from mail.palisadesystems.com (localhost.compliancesafe.com [127.0.0.1]) by ps-2-a.compliancesafe.com (8.14.4/8.14.3) with ESMTP id p5LGeAJh051062; Tue, 21 Jun 2011 11:40:10 -0500 (CDT) (envelope-from guy.helmer@palisadesystems.com) Received: from guysmbp.dyn.palisadesys.com (GuysMBP.dyn.palisadesys.com [172.16.2.90]) (authenticated bits=0) by mail.palisadesystems.com (8.14.3/8.14.3) with ESMTP id p5LGe4Iq037001 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 21 Jun 2011 11:40:05 -0500 (CDT) (envelope-from guy.helmer@palisadesystems.com) X-DKIM: Sendmail DKIM Filter v2.8.3 mail.palisadesystems.com p5LGe4Iq037001 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=palisadesystems.com; s=mail; t=1308674405; bh=U9Ie/T1VDtzlujMARog6Ujou1SkZDTucv9262zgUDCU=; l=128; h=Subject:Mime-Version:Content-Type:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=S9Xtn8QonYj2gImg3DpUZbN3ZXa/2lFWMneZWYs1bMe9K9PZFKg2nBjjxkerryKYC vOe2+iRQg3iF9xVaBIyCu1D8gdQ1TF160D25EpsQ5qtr554Gd5OSwyuHyB6zut09XK rmGS7B0bg9TnQqtrj/kQEyb1oLYDEUYLcdxQY1Ek= Mime-Version: 1.0 (Apple Message framework v1084) From: Guy Helmer In-Reply-To: Date: Tue, 21 Jun 2011 11:40:04 -0500 Message-Id: References: <201106202259.p5KMxT1h069297@svn.freebsd.org> <201106210907.18414.jhb@freebsd.org> <5B6CCF15-05B9-418A-8B84-6A2FF441A39C@palisadesystems.com> To: Jack Vogel X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.5 (mail.palisadesystems.com [172.16.1.5]); Tue, 21 Jun 2011 11:40:05 -0500 (CDT) X-Palisade-MailScanner-Information: Please contact the ISP for more information X-Palisade-MailScanner-ID: p5LGe4Iq037001 X-Palisade-MailScanner: Found to be clean X-Palisade-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-2.899, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90, HTML_MESSAGE 0.00) X-Palisade-MailScanner-From: guy.helmer@palisadesystems.com X-Spam-Status: No X-PacketSure-Scanned: Yes Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r223350 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 16:40:11 -0000 Ahh, I meant to say "global tunables". It is nice to have flow control as a per-interface setting also - didn't = have that back in FreeBSD 8.1. Thanks, Guy On Jun 21, 2011, at 11:34 AM, Jack Vogel wrote: > There IS a global default for flow control, its just hardcoded.. :) >=20 > Flow control was something my validation group specifically ragged on = me=20 > about... and was the reason I changed to a per-adapter setting. >=20 > Let me think about it. >=20 > Jack >=20 >=20 > On Tue, Jun 21, 2011 at 9:17 AM, Guy Helmer = wrote: > On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: >=20 >> LOL, the old adage is true, you just can't please all the people... = :)=20 >>=20 >> The way the code now is it assigns a default, but you could still = have >> a loader entry that would change it for all adapters if you wanted = to, >> but ok, if you prefer the older for this. What other globals do you=20= >> think should be retained? >>=20 >=20 > I'd like to be able to set the global default for flow control. I'd = also appreciate a global default for disabling TCP checksum offload, but = that's above and beyond what we had before :-) >=20 >> Jack >>=20 >>=20 >> On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin = wrote: >> On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: >> > Author: jfv >> > Date: Mon Jun 20 22:59:29 2011 >> > New Revision: 223350 >> > URL: http://svn.freebsd.org/changeset/base/223350 >> > >> > Log: >> > Eliminate some global tuneables in favor of adapter-specific, >> > particular flow control and dma coalesce. Also improve the >> > sysctl operation on those too. >> > >> > Add IPv6 detection in the ioctl code, this was done for >> > ixgbe first, carrying that over. >> > >> > Add resource ability to disable particular adapter. >> > >> > Add HW TSO capability so vlans can make use of TSO >>=20 >> The tunables are useful for setting defaults for all interfaces. :( >>=20 >> I use hw.igb.rx_processing_limit=3D-1 in loader.conf at work so that = we can >> ensure that all igb interfaces in a given system have that setting. = This is >> more scalable than having to set the right number of entries in >> /etc/sysctl.conf.local on different machines, etc, without spamming = the >> console during boot with warnings about tweaking non-existing = sysctls, etc. >>=20 >> Please consider keeping the tunables where the tunables are used to = set >> default settings for all adapters from the loader but per-device = sysctls are >> used post-boot to provide runtime, per-device settings. >>=20 >> -- >> John Baldwin >>=20 >=20 >=20 >=20 --------=0AThis message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.=0A