From owner-cvs-all@FreeBSD.ORG Tue Dec 28 21:50:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81C7216A579 for ; Tue, 28 Dec 2004 21:50:49 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50F6A43D41 for ; Tue, 28 Dec 2004 21:50:48 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8758 invoked from network); 28 Dec 2004 21:50:48 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 28 Dec 2004 21:50:47 -0000 Received: from [10.50.41.243] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iBSLoQg8095856; Tue, 28 Dec 2004 16:50:43 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Andrew R. Reiter" Date: Tue, 28 Dec 2004 10:48:42 -0500 User-Agent: KMail/1.6.2 References: <200412262252.iBQMqPe7060613@repoman.freebsd.org> <200412271600.26989.jhb@FreeBSD.org> <20041227172424.A85914@fledge.watson.org> In-Reply-To: <20041227172424.A85914@fledge.watson.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200412281048.42213.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: rwatson@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2004 21:50:50 -0000 On Monday 27 December 2004 05:27 pm, Andrew R. Reiter wrote: > On Mon, 27 Dec 2004, John Baldwin wrote: > :On Sunday 26 December 2004 07:54 pm, Kris Kennaway wrote: > :> On Sun, Dec 26, 2004 at 10:52:24PM +0000, Robert Watson wrote: > :> > rwatson 2004-12-26 22:52:24 UTC > :> > > :> > FreeBSD src repository > :> > > :> > Modified files: > :> > sys/kern subr_witness.c > :> > Log: > :> > Add "show alllocks" command to DDB, which dumps a list of processes > :> > and threads currently holding sleep mutexes (and spin mutexes for > :> > curthread). This can be quite useful in looking for a lock > :> > condition summary for a system, as it avoids manually iterating > :> > through threads and processes to find all the interesting locks. > :> > > :> > NB: "alllocks" is up there with "lockedvnods" for a bad argument for > :> > show. > :> > :> ITYM "allloks" or perhaps "alllockes" (conservation of vowels). > : > :If you want a better name you could do 'show locks /a' instead. That is, > : add support to 'show locks' for the /a option (see 'show ktr' for how you > : would handle this by looking at 'modif'). > > Seems like a good idea to me, John. My only -- very minor -- issue with > that is using '/' as the flag delimiter. Not trying to be an asshole or > anything, just seems to me that (unless there is some ddb options already > there that use '/') using the forward slash is very cmd.exe-esque. > > I agree, however, that having show locks is a good idea > instead of two different commands. The / is part of ddb itself. Each ddb command (except those that do their own command line parsing) is called with a variable containing the arguments and another variable (modif) containing a string of any options specified via /. For example: DB_SHOW_COMMAND(ktr, db_ktr_all) { int quit; quit = 0; tstate.cur = (ktr_idx - 1) & (KTR_ENTRIES - 1); tstate.first = -1; if (strcmp(modif, "v") == 0) db_ktr_verbose = 1; else db_ktr_verbose = 0; if (strcmp(modif, "a") == 0) { while (cncheckc() != -1) if (db_mach_vtrace() == 0) break; } else { db_setup_paging(db_simple_pager, &quit, db_lines_per_page); while (!quit) if (db_mach_vtrace() == 0) break; } } This implements 'show ktr' and allows 'show ktr /a' and 'show ktr /v'. Note that it doesn't handle 'show ktr /av' or 'show ktr /va'. :-) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org