From owner-svn-src-all@FreeBSD.ORG Wed Dec 8 18:30:04 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75DBF106566C; Wed, 8 Dec 2010 18:30:04 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-gw0-f49.google.com (mail-gw0-f49.google.com [74.125.83.49]) by mx1.freebsd.org (Postfix) with ESMTP id C79758FC1D; Wed, 8 Dec 2010 18:30:03 +0000 (UTC) Received: by gwj20 with SMTP id 20so997822gwj.36 for ; Wed, 08 Dec 2010 10:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=8AnOMfI2f+Ax/LYzb40jWdPDByAdlww/e3nWBA/tdJ0=; b=SjLl6pfj/g3FV14Paymn5gU5ZPT/tQ8vonb/CN4DvIvPIBw59lBMgCHbHzMs+v8CDr fUyMwEfzKp3whbN9qiVf5okCsKtGlwf44o7Ezt3r3OdaHAhcU+BRsA3+Md/hB3XPaTW8 YTGPvVbFQDgotobQVCozJlub3+pvzeXPp6GWw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=cE9GeU5Y49HlujRSz8E8PqBrpWw1OAM/DzDzkwZDs06wqL7dJBr4mjKQpcptVUS5fl PzLPFoIkAoo1t/lEHsx1r29LGS2ZGJosRLyh7KJ5cAYN1i+eK1Qalz9/FuiM4fGPEMI8 z2syW4JFthBRj+YrjEhPT80wU+uALXCAGtelM= Received: by 10.151.6.15 with SMTP id j15mr4461335ybi.391.1291833002874; Wed, 08 Dec 2010 10:30:02 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id f4sm125635ybi.11.2010.12.08.10.29.59 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 08 Dec 2010 10:30:01 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Wed, 8 Dec 2010 10:30:04 -0800 From: Pyun YongHyeon Date: Wed, 8 Dec 2010 10:30:04 -0800 To: Hans Petter Selasky Message-ID: <20101208183004.GA10892@michelle.cdnetworks.com> References: <201012080124.oB81O5Te086075@svn.freebsd.org> <201012080826.50794.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012080826.50794.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Pyun YongHyeon Subject: Re: svn commit: r216284 - head/sys/dev/usb/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2010 18:30:04 -0000 On Wed, Dec 08, 2010 at 08:26:50AM +0100, Hans Petter Selasky wrote: > On Wednesday 08 December 2010 02:24:05 Pyun YongHyeon wrote: > > - if (m->m_pkthdr.len > MCLBYTES) { > > - m->m_pkthdr.len = MCLBYTES; > > - } > > You are sure that no packets passed to this code is bigger than MCLBYTES minus > overhead by AXE protocol ? Even if MTU is changed by ifconfig? > Yes and Yes. axe(4) uses uether_ioctl which in turn calls default ether_ioctl. Users have no way to use jumbo frame on axe(4) since ether_ioctl does not allow it. Actually axe(4) supports jumbo frame but I don't think it's worth to implement it due to many limitation of USB ethernet controller. > --HPS