From owner-freebsd-embedded@FreeBSD.ORG Wed Dec 21 15:13:49 2011 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E7A81065670; Wed, 21 Dec 2011 15:13:49 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea]) by mx1.freebsd.org (Postfix) with ESMTP id 54D7C8FC14; Wed, 21 Dec 2011 15:13:49 +0000 (UTC) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 273DF112F0D; Wed, 21 Dec 2011 16:13:48 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=iso-8859-1 From: Stefan Bethke In-Reply-To: Date: Wed, 21 Dec 2011 16:13:47 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <09670C34-0D30-46BC-BA7E-4AAA22193B61@lassitu.de> References: <0F6CC18F-6973-42A2-AC03-F01BF59458AE@lassitu.de> <1100F70E-9DA9-4163-AC9A-423ECE5AA9A3@lassitu.de> <18CABB46-9B9A-41CB-8742-6723C5FF4D67@lassitu.de> <2CBD8651-E132-49DC-A082-37A8F5C626EA@bsdimp.com> To: Adrian Chadd X-Mailer: Apple Mail (2.1251.1) Cc: Oleksandr Tymoshenko , "freebsd-embedded@freebsd.org" Subject: Re: Updated switch/glue patch? X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2011 15:13:49 -0000 Am 20.12.2011 um 16:25 schrieb Adrian Chadd: >> I'm of two minds whether reusing the miibus code really is a good = idea. The problem I have with it is mainly that it assumes that there = is a struct ifnet that the miibus is attached to, and that that ifnet = has exactly one running phy. So in my current implementation, I've = simply created one ifnet for each of the five ports that have PHYs on = them. >=20 > I personally think your current method of doing it is fine. The switch > driver is small, it's reusing the media handling infrastructure; it > doesn't look like you'll have to do much to write a custom PHY to > replace ukphy. I've replaced the generic PHY status poll with a custom one that uses = the switch registers instead of the PHYs. I've cloned your git and have = started adding my changes to it (branch also named work/ath): http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work I tried a merge request, but gitorious didn't like it (at least at the = top level). Stefan --=20 Stefan Bethke Fon +49 151 14070811