From owner-freebsd-net@FreeBSD.ORG Tue Mar 17 08:13:02 2009 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D172106566C; Tue, 17 Mar 2009 08:13:02 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out2.smtp.messagingengine.com (out2.smtp.messagingengine.com [66.111.4.26]) by mx1.freebsd.org (Postfix) with ESMTP id 0D7408FC16; Tue, 17 Mar 2009 08:13:01 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 868352F2073; Tue, 17 Mar 2009 04:13:01 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Tue, 17 Mar 2009 04:13:01 -0400 X-Sasl-enc: mXSuPPtFQkLbGPBuDxlcHhbqGaJU8w1WoQ4GiqFiP6Sk 1237277581 Received: from anglepoise.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id C709E282F8; Tue, 17 Mar 2009 04:13:00 -0400 (EDT) Message-ID: <49BF5B8A.4040108@incunabulum.net> Date: Tue, 17 Mar 2009 08:12:58 +0000 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.19 (X11/20090125) MIME-Version: 1.0 To: Sam Leffler References: <1236937253.2282.0.camel@localhost> <49BAEA9F.8020302@incunabulum.net> <49BB0D3E.2020306@incunabulum.net> <49BC1C66.7030400@freebsd.org> <1237233210.84180.20.camel@localhost> <49BEB312.7060105@freebsd.org> In-Reply-To: <49BEB312.7060105@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org, Coleman Kane , freebsd-net Subject: Re: IGMP+WiFi panic on recent kernel - in igmp_fasttimo() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2009 08:13:02 -0000 Sam Leffler wrote: > It is the same issue but the root cause is unclear. There is much > code that does assumes ifma_protospec might be NULL and checks for > it. In my case (creating a wlan ifnet and then destroying it on > eject) the patch below is sufficient. I don't care to dig right now > to understand how this stuff is supposed to work; it should be clear > from comments etc but the code is lacking. > This is just to say I've tried to reproduce the 802.11 related panics, however have hit a brick wall because the PCI-CardBus bridge does not seem to detect anything in its slot. (1U Itox Expanding Dragon industrial PC w/a SiteCom branded Ricoh RL475 cardbus card). I tried unloading if_fxp with IGMPv3 active on the ifnet, and didn't see any panic, I'm assuming this is OK for the time being. Qing Li volunteered to test IGMPv3 out for any VLAN related issues -- I understand it stacks ifnets in a similar way to that of 802.11 -- however I have had no feedback from him since last week. So I'm waiting for a HEAD build to a USB2 stick to finish, so I can try testing nondestructively on my laptop, where I know for sure that the PCI-CardBus bridge slot works, and I can detach an 802.11 card on the fly. Re ifma_protospec: Yes, there are tricks in the ifnet/in layer which set it to NULL and look for it to be NULL. I ended up doing it this way mainly because adding reference counting to ifnet would have simply been too much work, and it's really a ball that needs to be kicked around at a dev summit. However time presses on and it's better to get SOMETHING out there. Most likely the IGMPv3 changes are hitting this in the 802.11 case somehow, I don't have a complete picture of how/why/what's going on, and have been relying on feedback from others so far. cheers BMS