From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 22 19:12:49 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2692B16A420;
	Wed, 22 Feb 2006 19:12:49 +0000 (GMT)
	(envelope-from nielsen@memberwebs.com)
Received: from mail.npubs.com (mail.wsfamily.com [209.66.100.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 25F5D43D7B;
	Wed, 22 Feb 2006 19:12:42 +0000 (GMT)
	(envelope-from nielsen@memberwebs.com)
From: Nate Nielsen <nielsen@memberwebs.com>
User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
References: <200602221810.k1MIA5dR035468@freefall.freebsd.org>
X-Enigmail-Version: 0.92.0.0
Content-Type: multipart/mixed; boundary="------------030305000202070609050606"
Message-Id: <20060222192219.85E4FDCA99E@mail.npubs.com>
X-Virus-Scanned: ClamAV using ClamSMTP
Date: Wed, 22 Feb 2006 19:22:20 +0000 (GMT)
Cc: 
Subject: Re: kern/93720: Kernel Dump to USB umass device
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2006 19:12:49 -0000

This is a multi-part message in MIME format.
--------------030305000202070609050606
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Patch which fixes the problem.

--------------030305000202070609050606
Content-Type: text/x-patch;
 name="umass-ohci-dump.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="umass-ohci-dump.patch"

Index: sys/dev/usb/umass.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v
retrieving revision 1.122.2.6
diff -U3 -r1.122.2.6 umass.c
--- sys/dev/usb/umass.c	29 Jan 2006 00:45:11 -0000	1.122.2.6
+++ sys/dev/usb/umass.c	22 Feb 2006 03:04:02 -0000
@@ -2643,21 +2643,17 @@
 	}
 }
 
-/* umass_cam_poll
- *	all requests are handled through umass_cam_action, requests
- *	are never pending. So, nothing to do here.
- */
 Static void
 umass_cam_poll(struct cam_sim *sim)
 {
-#ifdef USB_DEBUG
 	struct umass_softc *sc = (struct umass_softc *) sim->softc;
 
 	DPRINTF(UDMASS_SCSI, ("%s: CAM poll\n",
 		USBDEVNAME(sc->sc_dev)));
-#endif
 
-	/* nop */
+	usbd_set_polling(sc->sc_udev, 1);
+	usbd_dopoll(sc->iface);
+	usbd_set_polling(sc->sc_udev, 0);
 }
 
 
Index: sys/dev/usb/ohci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/ohci.c,v
retrieving revision 1.154.2.2
diff -U3 -r1.154.2.2 ohci.c
--- sys/dev/usb/ohci.c	29 Jan 2006 01:26:46 -0000	1.154.2.2
+++ sys/dev/usb/ohci.c	22 Feb 2006 03:04:05 -0000
@@ -3049,6 +3049,9 @@
 
 	splx(s);
 
+	if (sc->sc_bus.use_polling)
+		ohci_waitintr(sc, xfer);
+
 	return (USBD_IN_PROGRESS);
 }
 

--------------030305000202070609050606--