From owner-freebsd-current  Sat Aug 21  5: 0: 1 1999
Delivered-To: freebsd-current@freebsd.org
Received: from dyson.iquest.net. (iq-ind-dns003-90.iquest.net [198.70.149.90])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4BDE614FA3; Sat, 21 Aug 1999 04:59:54 -0700 (PDT)
	(envelope-from toor@dyson.iquest.net)
Received: (from toor@localhost)
	by dyson.iquest.net. (8.9.3/8.9.3) id GAA20231;
	Sat, 21 Aug 1999 06:56:38 -0500 (EST)
	(envelope-from toor)
Message-Id: <199908211156.GAA20231@dyson.iquest.net.>
Subject: Re: NFS HEADS UP (was Re: cvs commit: src/sys/nfs nfsm_subs.h xdr_subs.h)
In-Reply-To: <199908191829.LAA57025@apollo.backplane.com> from Matthew Dillon at "Aug 19, 1999 11:29:31 am"
To: dillon@apollo.backplane.com (Matthew Dillon)
Date: Sat, 21 Aug 1999 06:56:38 -0500 (EST)
Cc: bright@rush.net (Alfred Perlstein),
	eivind@FreeBSD.ORG (Eivind Eklund), peter@FreeBSD.ORG (Peter Wemm),
	current@FreeBSD.ORG
From: "John S. Dyson" <dyson@iquest.net>
Reply-To: dyson@iquest.net
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Matthew Dillon said:
> :>     global references across subroutine calls!  I'll send Luoqi another email.
> :> 
> :>     In the case of the NFS stuff, the changes have been pretty well tested
> :>     so I think we are in the clear.
> :
> :On a somewhat similar note, what do you think about converting a lot
> :of the NFS macros to functions, yes i know it will be difficult, but
> :there is so much forced inlining it just seems like it would reduce
> :the codesize signifigantly and play nicer with the CPU cache.
> :
> :It would also make the code a lot more readable.
> :
> :Worthwhile exercise?
> :
> :-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] 
> 
>     Well, the issue with converting many of the macros to inline functions
>     is with the embedded goto's and references to variables defined outside 
>     the macros.  Converting them to functions would basically require 
>     rewriting a huge chunk of NFS code.  
> 
My working kernel runs with a few strategic NFS macros being converted
to functions, and the size improvement is about 50K or so (maybe more!!!)

John


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message