From owner-freebsd-mobile  Tue Jun 26 14:51:28 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id DCA3A37B401
	for <freebsd-mobile@FreeBSD.ORG>; Tue, 26 Jun 2001 14:51:23 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.1) with ESMTP id f5QLpHU10183;
	Tue, 26 Jun 2001 15:51:18 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200106262151.f5QLpHU10183@harmony.village.org>
To: Ian Dowse <iedowse@maths.tcd.ie>
Subject: Re: Pccard hangs in -stable (new problem in pcic.c r1.89.2.6) 
Cc: freebsd-mobile@FreeBSD.ORG
In-reply-to: Your message of "Tue, 26 Jun 2001 22:44:55 BST."
		<200106262244.aa73609@salmon.maths.tcd.ie> 
References: <200106262244.aa73609@salmon.maths.tcd.ie>  
Date: Tue, 26 Jun 2001 15:51:17 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-mobile.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-mobile>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-mobile>
X-Loop: FreeBSD.org

In message <200106262244.aa73609@salmon.maths.tcd.ie> Ian Dowse writes:
: In message <200106262137.f5QLbHU09935@harmony.village.org>, Warner Losh writes:
: >Except that the registers that exist on the Vadem controllers don't
: >exist on any other kinds of bridges.
: 
: Oops - but it was certainly the addition of the 'case PCIC_I82365:'
: that caused the new problems. Should the
: 
: 		else
: 			setb(sp, PCIC_MISC1, PCIC_MISC1_VCC_33);
: 
: just become something like
: 
: 		else if (sp->controller != PCIC_I82365)
: 			setb(sp, PCIC_MISC1, PCIC_MISC1_VCC_33);
: 
: instead in both cases? I should have been more specific in saying
: that I hadn't tested the proposed patch :-)

That's likely a better patch.  However, the power issues are more
complex than -stable codifies.  -current attempts to take care of this
by using flags for each controller type.  The 3.3V power is different
for each bridge, so it seems.  One for Intel 82365 step d, one for
cirrus logic, one for vadem and one for ricoh parts.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message