From owner-cvs-all Fri Nov 10 4:50:44 2000 Delivered-To: cvs-all@freebsd.org Received: from blount.mail.mindspring.net (blount.mail.mindspring.net [207.69.200.226]) by hub.freebsd.org (Postfix) with ESMTP id 1166B37B479; Fri, 10 Nov 2000 04:50:38 -0800 (PST) Received: from silvia.hip.berkeley.edu (sji-ca7-217.ix.netcom.com [209.109.235.217]) by blount.mail.mindspring.net (8.9.3/8.8.5) with ESMTP id HAA27234; Fri, 10 Nov 2000 07:50:32 -0500 (EST) Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.11.1/8.11.0) id eAACoQ865760; Fri, 10 Nov 2000 04:50:26 -0800 (PST) (envelope-from asami@cs.berkeley.edu) X-Authentication-Warning: silvia.hip.berkeley.edu: asami set sender to asami@cs.berkeley.edu using -f To: Steve Price Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/cad/pisces Makefile References: <200011082255.OAA06620@freefall.freebsd.org> <20001109201421.R62344@bonsai.knology.net> From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami) MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu") Content-Type: text/plain; charset=US-ASCII Date: 10 Nov 2000 04:50:19 -0800 In-Reply-To: <20001109201421.R62344@bonsai.knology.net> (Steve Price's message of "Thu, 9 Nov 2000 20:14:21 -0600") Message-ID: Lines: 54 User-Agent: T-gnus/6.14.5 (based on Gnus v5.8.7) (revision 06) SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/20.7 (i386--freebsd) MULE/4.0 =?ISO-2022-JP?B?KBskQjJWMWMbKEIp?= Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * From: Steve Price * # BUILD_DEPENDS= imake-4 * # USE_XLIB= yes (which translates to LIB_DEPENDS=XFree86 3 or 4) * # Which means, a problem only arises when the user has XFre86-3 not * # installed, in which case BUILD_DEPENDS=imake-4 will install imake-4 * # and LIB_DEPENDS to XFree86-3 will install XFree86-3 (including * # imake). Is that what you noticed? * * Yes this scenario was the one that bothered me. Although I guess * in hindsight the commit was more from a selfish perspective to * keep my one lonely, little Alpha machine building packages * without having to go back and cull out a bunch of ports that * looked broken but really weren't. No, I understand where you are coming from. The old code was only intended to be a stopgap until we switch to XFree86-4 as the default. It basically assumed you either already have XFree86-3 installed, or already set XFREE86_VERSION=4. (Like, nobody in their right mind would let XFree86-3 build from a dependency. :) * I'd like to see NEED_IMAKE either way. There are a number of * ports that use imake but hack up furballs with USE_IMAKE. In * fact, the port in question (cad/pisces) is one of them. I * don't know of many ports (if any) that NEED_IMAKE but don't * USE_XLIB. However, we probably shouldn't have NEED_IMAKE imply * USE_XLIB. Actually there are a few: === >> grep imake /usr/ports/INDEX | grep -v XFree86 | awk -F '|' '{print $1}' ilu-2.0a13 ja-Canna-3.2.2 ja-Wnn6-lib-98.10.28 ja-canuum-1.0 ja-sj3-2.0.1.20 === So you are right about NEED_IMAKE not implying USE_XLIB. I'll conjure up a patch after I dig myself out of this huge pile of work I'm buried under. * Once 4.2 gets out the door I'd be willing to go with the latter * too. :) :) Speaking of which, we might need a NEED_AUTOMAKE too. (See graphics/graphviz/Makefile.) Satoshi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message