From owner-freebsd-pf@FreeBSD.ORG Thu Nov 18 16:16:59 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ACD916A4CE for ; Thu, 18 Nov 2004 16:16:59 +0000 (GMT) Received: from mail.secureworks.net (mail.secureworks.net [209.101.212.155]) by mx1.FreeBSD.org (Postfix) with SMTP id C19E743D49 for ; Thu, 18 Nov 2004 16:16:58 +0000 (GMT) (envelope-from mdg@secureworks.net) Received: (qmail 42514 invoked from network); 18 Nov 2004 16:16:57 -0000 Received: from unknown (HELO HOST-192-168-8-243.internal.secureworks.net) (63.239.86.253) by mail.secureworks.net with SMTP; 18 Nov 2004 16:16:57 -0000 Date: Thu, 18 Nov 2004 11:16:57 -0500 (EST) From: Matthew George X-X-Sender: mdg@localhost To: Max Laier In-Reply-To: <200411180200.10755.max@love2party.net> Message-ID: <20041118111240.M65727@localhost> References: <200411180200.10755.max@love2party.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-pf@freebsd.org Subject: Re: please test: ifstated(8) patches X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2004 16:16:59 -0000 On Wed, 17 Nov 2004, Max Laier wrote: > On Wednesday 17 November 2004 22:54, Matthew George wrote: > > I've gone and ported OpenBSD's ifstated(8) to FreeBSD. > > Nice! Good that you found the sysctl's to substitute the SIOCGIFDATA > ioctl. I > haven't yet had time to look at it, but that seems to close bin/73877 > [1], or > is there any functionality that you are missing? Doesn't look like it > from > your diff. looks good to me > > > The attached ifstated.patch will apply against src/usr.sbin/ifstated/* > > from OpenBSD's cvs, and compiles cleanly against RELENG_5_3. > > Very nice, would you mind to turn it into a proper port? Just drop me a > tarball if you don't have somewhere to host it. I don't know if ifstated > > should go into the base-system. It looks like it should be able to run > as a > port just fine? sure thing ... I'll wrap it up and PR it today or tomorrow > > > The ifstated.conf.patch is basically the same as OpenBSD's, except for > a > > ping command line option. The config file has a comment in it noting > that > > net.inet.carp.preempt must be set to '1' in order for it to work. I > > performed my testing with it set to '0', and it seemed to be fine for > me. > > Is there a problem with preempt in the patchset right now? I didn't test it, so I'm not sure. The comment was from OpenBSD ... > > > The config script calls ifconfig on carp interfaces for its actions, > but > > that's the only requirement for carp ... it should work fine for > non-carp > > kernels with the proper config script. > > Again, thanks a lot! > Everybody, please help testing. > > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/73877 > > -- Matthew George SecureWorks Technical Operations 404.327.6339