From owner-freebsd-i386@FreeBSD.ORG Wed Apr 25 19:06:37 2007 Return-Path: X-Original-To: freebsd-i386@freebsd.org Delivered-To: freebsd-i386@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4E9B116A400; Wed, 25 Apr 2007 19:06:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id C9EDE13C455; Wed, 25 Apr 2007 19:06:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3PJ6Yuc068508; Wed, 25 Apr 2007 15:06:34 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ariff Abdullah Date: Wed, 25 Apr 2007 14:10:04 -0400 User-Agent: KMail/1.9.6 References: <20070420195444.20bc4d3a.ariff@FreeBSD.org> <200704241147.57194.jhb@freebsd.org> <20070425011720.5725e654.ariff@FreeBSD.org> In-Reply-To: <20070425011720.5725e654.ariff@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704251410.04512.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 25 Apr 2007 15:06:34 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3161/Wed Apr 25 11:52:16 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-i386@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: AMD64 K8 Family C1E dead apic timer fixup X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 19:06:37 -0000 On Tuesday 24 April 2007 01:17:20 pm Ariff Abdullah wrote: > On Tue, 24 Apr 2007 11:47:56 -0400 > John Baldwin wrote: > > On Monday 23 April 2007 09:39:59 pm Ariff Abdullah wrote: > > > On Mon, 23 Apr 2007 14:46:53 -0400 > > > John Baldwin wrote: > > > > On Friday 20 April 2007 07:54:44 am Ariff Abdullah wrote: > > > > > Will anybody object if I (or somebody else) commit this patch? > > > > > > > > > > http://people.freebsd.org/~ariff/test/k8_c1e.diff > > > > > > > > > > This should "fix" dead apic timer issues on latest AMD64 > > > > > (Turion64 X2 mostly, or later revision) where C1 Enhanced > > > > > (C1E) mode enabled. > > > > > > > > > > Without this, the only way to make the timer work is to > > > > > disable APIC or even worst, to avoid executing HLT instruction > > > > > (machdep.cpu_idle_hlt=0), smp or non-smp. It affect both i386 > > > > > and amd64. > > > > > > > > > > See PR: i386/104678 for details. > > > > > > > > Does this fix all of the Turion lapic timer hangs? > > > > > > Yes, and hopefully to the later revisions (if any) as well. > > > > Ok, cool. > > > > > > Some small tweaks to the comment would be: > > > > > > > > - s/present/presence/ > > > > - s/render/renders/ > > > > - s/apic timer/local APIC timer/ > > > > - s/dead, and/dead, so/ > > > > - s/reading Interrupt/reading the Interrupt/ > > > > - s/unset/clearing/ > > > > > > > > > > Thanks. > > > > > > > Also, is it ok to always mask off the upper 31 bits of the MSR > > > > instead of preserving their current state? > > > > > > > It should work either way, since the upper bits are read only. > > > > Why bother masking it off then? > > > > Except of my personal tendency to kill it, I don't think we need to > mask it off. See latest patch (same link). Go for it. -- John Baldwin