From owner-svn-src-user@FreeBSD.ORG Fri Oct 17 22:32:26 2008 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F8481065686; Fri, 17 Oct 2008 22:32:26 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from k7.mavetju.org (ppp121-44-136-21.lns10.syd7.internode.on.net [121.44.136.21]) by mx1.freebsd.org (Postfix) with ESMTP id 317368FC15; Fri, 17 Oct 2008 22:32:24 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by k7.mavetju.org (Postfix, from userid 1001) id 16A604503D; Sat, 18 Oct 2008 09:31:37 +1100 (EST) Date: Sat, 18 Oct 2008 09:31:37 +1100 From: Edwin Groothuis To: Alexander Leidinger Message-ID: <20081017223137.GD71466@mavetju.org> References: <200810161058.m9GAw0ua059956@svn.freebsd.org> <20081017070044.GC71466@mavetju.org> <20081017112433.24936er2myfi9pwc@webmail.leidinger.net> <20081017105138.GR71453@mavetju.org> <20081017111451.GA67097@rink.nu> <20081017135659.41525zeb0tv4avgo@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081017135659.41525zeb0tv4avgo@webmail.leidinger.net> User-Agent: Mutt/1.4.2.3i Cc: Rink Springer , src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r183951 - user/netchild/obsolete/src/libexec/tftpd X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2008 22:32:26 -0000 On Fri, Oct 17, 2008 at 01:56:59PM +0200, Alexander Leidinger wrote: > Quoting Rink Springer (from Fri, 17 Oct 2008 > 13:14:51 +0200): > > >On Fri, Oct 17, 2008 at 09:51:38PM +1100, Edwin Groothuis wrote: > >>On Fri, Oct 17, 2008 at 11:24:33AM +0200, Alexander Leidinger wrote: > >>> Quoting Edwin Groothuis (from Fri, 17 Oct 2008 > >>> 18:00:44 +1100): > >>> > >>> >On Thu, Oct 16, 2008 at 10:58:00AM +0000, Alexander Leidinger wrote: > >>> >> The correct spelling is EACCES, not EACCESS. > >>> >[...] > >>> >>- { EACCESS, "Access violation" }, > >>> >>+ { EACCES, "Access violation" }, > >>> > > >>> >I am not sure what you mean with this... What is exactly wrong with > >>> >the last S in EACCESS ? > >>> > >>> "man errno" does not list EACCESS, it only lists EACCES. > >> > >>True, but this is a TFTP error, not a system call return value. > >>See also the Appendix "Error Codes" of RFC1350. > > > >Wouldn't using definitions like 'TFTP_Exxx' make more sense, to prevent > >possible confusion as these are TFTP-specific error values? > > Boy, this is not only confusing, it's also dangerous. There's more > than only the EACCESS very near to named errno values. I fully agree > with Rink, specially as the RFC only specifies error values, not > symbolic names. I've updated my code in r183992 and r183993, also for the opcodes. Edwin -- Edwin Groothuis Website: http://www.mavetju.org/ edwin@mavetju.org Weblog: http://www.mavetju.org/weblog/