From owner-freebsd-acpi@FreeBSD.ORG  Fri Apr 14 09:06:59 2006
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
X-Original-To: acpi@freebsd.org
Delivered-To: freebsd-acpi@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 23D3F16A400;
	Fri, 14 Apr 2006 09:06:59 +0000 (UTC)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from locore.org (ns01.locore.org [218.45.21.227])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 66BE743D45;
	Fri, 14 Apr 2006 09:06:58 +0000 (GMT)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (ns01.locore.org [218.45.21.227])
	by locore.org (8.13.6/8.13.6/iwasaki) with ESMTP/inet id k3E96lA0024205;
	Fri, 14 Apr 2006 18:06:50 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Fri, 14 Apr 2006 18:06:22 +0900 (JST)
Message-Id: <20060414.180622.30189283.iwasaki@jp.FreeBSD.org>
To: nate@root.org
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <443F54DF.3080809@root.org>
References: <443C027B.7050002@root.org>
	<20060413.012156.56054177.iwasaki@jp.FreeBSD.org>
	<443F54DF.3080809@root.org>
X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: acpi@freebsd.org, current@freebsd.org
Subject: Re: CFR: ACPI Dock driver
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Apr 2006 09:06:59 -0000

Hi,

> I looked and found you use acpi_GetReference() already in acpi_dock.c. 
> So no idea what I meant, must have misread something.

OK, understood.

> One other thing:  you explicitly call _INI.  acpi-ca should be doing 
> that for you already, is it not?

According to nsinit.c:AcpiNsInitOneDevice(), _INI is never be called
when _STA return zero (the value if undocked).
Also _INI is called only in acpi_dock_attach(), so I think it doesn't
hurt anything.

I'll try to test this more tonight...

Thanks