From owner-freebsd-scsi  Fri Apr 20  1: 2:51 2001
Delivered-To: freebsd-scsi@freebsd.org
Received: from axis.tdd.lt (axis.tdd.lt [193.219.211.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 113F337B424; Fri, 20 Apr 2001 01:02:46 -0700 (PDT)
	(envelope-from domas.mituzas@delfi.lt)
Received: from localhost (midom@localhost)
	by axis.tdd.lt (8.11.1/8.11.1) with ESMTP id f3K82hn35267;
	Fri, 20 Apr 2001 10:02:43 +0200 (EET)
Date: Fri, 20 Apr 2001 10:02:42 +0200 (EET)
From: Domas Mituzas <domas.mituzas@delfi.lt>
X-X-Sender:  <midom@axis.tdd.lt>
To: Mike Smith <msmith@freebsd.org>
Cc: <scsi@freebsd.org>, <jkh@freebsd.org>, <vd@sampo.lt>
Subject: Re: mly driver does not work with SCA in up-to-date 4.3 
In-Reply-To: <200104200137.f3K1bUu17530@mass.dis.org>
Message-ID: <20010420100053.I34482-100000@axis.tdd.lt>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-scsi@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


> I think you're booting verbose; this shouldn't actually show up normally
> AFAIR.
booting in normal mode gave just mly gone messages. of course I did
verbose boot.

>             /* convert speed (MHz) to usec */
>             cts->sync_period = 1000000 / sc->mly_btl[bus][target].mb_speed;
>
> and the problem is that the device isn't considered a "physical" device
> by the Mylex controller.  You might try something like
>
> 	if (sc->mly_btl[bus][target].mb_speed == 0) {
> 		cts->sync_period = 1000000 / 5;
> 	} else {
> 		cts->sync_period = 1000000 / sc->mly_btl[bus][target].mb_speed;
> 	}
>

Yes, it solved that division by zero problem. Thanks! It would be really
nice to see this patch in 4.3-rel.

Regards,
Domas Mituzas

--- src/sys/dev/mly/mly_cam.c.old	Fri Apr 20 09:59:04 2001
+++ src/sys/dev/mly/mly_cam.c	Fri Apr 20 09:59:14 2001
@@ -363,7 +363,11 @@
 	    cts->valid |= CCB_TRANS_TQ_VALID;

 	    /* convert speed (MHz) to usec */
-	    cts->sync_period = 1000000 / sc->mly_btl[bus][target].mb_speed;
+	    if (sc->mly_btl[bus][target].mb_speed == 0) {
+		cts->sync_period = 1000000 / 5;
+	    } else {
+	        cts->sync_period = 1000000 / sc->mly_btl[bus][target].mb_speed;
+	    }

 	    /* convert bus width to CAM internal encoding */
 	    switch (sc->mly_btl[bus][target].mb_width) {


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message