From owner-freebsd-ports  Fri Jul 27  5:54:52 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1798537B407; Fri, 27 Jul 2001 05:54:49 -0700 (PDT)
	(envelope-from tobez@FreeBSD.org)
Received: (from tobez@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f6RClB008747;
	Fri, 27 Jul 2001 05:47:11 -0700 (PDT)
	(envelope-from tobez)
Date: Fri, 27 Jul 2001 05:47:11 -0700 (PDT)
From: <tobez@FreeBSD.org>
Message-Id: <200107271247.f6RClB008747@freefall.freebsd.org>
To: martti.kuparinen@iki.fi, tobez@FreeBSD.org,
	freebsd-ports@FreeBSD.org
Subject: Re: ports/29161: [MAINTAINER PATCH] p5-IMAP-Admin
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

Synopsis: [MAINTAINER PATCH] p5-IMAP-Admin

State-Changed-From-To: open->feedback
State-Changed-By: tobez
State-Changed-When: Fri Jul 27 05:32:54 PDT 2001
State-Changed-Why: 
Examining the source code, I was only able to find a single 5.6.X
specificity, namely `use IO::Socket::INET' statement at the beginning of
Admin.pm file.

You also seem to forget that -current already has 5.6.0 in the base
system.

So basically I can see several different ways to handle the problem:

1.  Forbid the port conditionally, depending on the FreeBSD version.
Please see textproc/p5-Text-FixedLength-Extra port as an example.

2.  Patch the port *removing* the line `use IO::Socket::INET'.  This
will work in -stable because the IO::Socket module contains
IO::Socket::INET package in it, and this will work in -current since
IO::Socket module uses IO::Socket::INET to preserve
backward-compatibility.

3. Make the port to depend on devel/p5-IO, which includes
IO::Socket::INET.

Personally, I prefer (2) myself.  The only case when (1) is better is
if there are more 5.6.X specificities which I missed somehow.

Please choose what to do, and submit the patch, if any, as the followup
to this PR;  there is really no need to open a new PR for this.  :-)

=Anton.

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29161

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message