From owner-freebsd-emulation@FreeBSD.ORG Thu Dec 1 14:20:45 2005 Return-Path: X-Original-To: emulation@freebsd.org Delivered-To: freebsd-emulation@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D116616A41F; Thu, 1 Dec 2005 14:20:45 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 974E043D81; Thu, 1 Dec 2005 14:20:37 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5F67A.dip.t-dialin.net [84.165.246.122]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id jB1Drhtu023225; Thu, 1 Dec 2005 14:53:49 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id jB1EKQ4H033888; Thu, 1 Dec 2005 15:20:26 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 01 Dec 2005 15:20:26 +0100 Message-ID: <20051201152026.lxwvpjokc0sw0okc@netchild.homeip.net> X-Priority: 3 (Normal) Date: Thu, 01 Dec 2005 15:20:26 +0100 From: Alexander Leidinger To: Jean-Yves Lefort References: <200511261918.jAQJIp91001719@repoman.freebsd.org> In-Reply-To: <200511261918.jAQJIp91001719@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: emulation@freebsd.org Subject: Re: cvs commit: ports/audio/linux-openal bsd.linux.mk X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2005 14:20:46 -0000 Jean-Yves Lefort wrote: [moving to emulation@] I have a backlog of cvs-all mails... I'm slowly catching up and noticed this one without further looking if someone wrote some comments (but I looked at rev 1.2 of the file). > jylefort 2005-11-26 19:18:51 UTC > > FreeBSD ports repository > > Added files: > audio/linux-openal bsd.linux.mk > Log: > Add my RPM support infrastructure. ^^ Isn't this a little bit selfish? ;-) Ok, more serious comments (*constructive* critic): - that's the wrong name for this file, bsd.rpm.mk or bsd.linuxrpm.mk would be better, since it does not contain all linux related mk-fu - install-time generated plists are evil (as per discussion on ports@ a while ago (and as of very recent experience with the linux ports), so the pre-install target should be removed and a real plist should be generated), have a look at the linux-gtk Makefile for a target which generates an initial plist (needs to be modified a little bit afterwards) - it should be installed into PORTSDIR/Mk, so that other port can use it - does the ppc have a linuxolator? - why do you use different ways of specifying the paths in DESCR and MD5_FILE? - why do you specify DESCR at all? - INSTALLS_LINUX_SHLIB should be removed, fix the FreeBSD one instead to not do anything in the USE_LINUX case and reuse the name of the FreeBSD one (-> more consistent and easy description on the porters handbook) In general it's nice to see someone working on this. And I like the idea to use rpm2cpio instead of rpm. We could get rid of the rpm-db in the linux base ports this way (this removes some of those annoying warnings on pkg_deinstall). Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Insanity is the final defense. It's hard to get a refund when the salesman is sniffing your crotch and baying at the moon.