From owner-freebsd-ports@FreeBSD.ORG Mon May 11 14:35:22 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BE621065674 for ; Mon, 11 May 2009 14:35:22 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (mailrelay.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id A0E2F8FC22 for ; Mon, 11 May 2009 14:35:21 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 2CE141990B2; Mon, 11 May 2009 16:35:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 1EA5D1990A0; Mon, 11 May 2009 16:35:18 +0200 (CEST) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id E6E4119909D; Mon, 11 May 2009 16:35:17 +0200 (CEST) Received: from wep4035 ([132.187.37.35]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.2HF443) with ESMTP id 2009051116351762-20376 ; Mon, 11 May 2009 16:35:17 +0200 Received: by wep4035 (sSMTP sendmail emulation); Mon, 11 May 2009 16:35:17 +0200 Date: Mon, 11 May 2009 16:35:17 +0200 From: Alexey Shuvaev To: Wesley Shields Message-ID: <20090511143517.GA48334@wep4035.physik.uni-wuerzburg.de> References: <4ad871310905101008n73d26145h3d81914925aab965@mail.gmail.com> <4ad871310905101222g63867982p6161ff0ddd1b6850@mail.gmail.com> <20090511131700.GA47969@atarininja.org> MIME-Version: 1.0 In-Reply-To: <20090511131700.GA47969@atarininja.org> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.19 (2009-01-05) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 05/11/2009 04:35:17 PM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 05/11/2009 04:35:17 PM, Serialize complete at 05/11/2009 04:35:17 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: Marcin Wisnicki , freebsd-ports@freebsd.org Subject: Re: [RFC] NO_INSTALL in meta-ports considered harmful X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2009 14:35:22 -0000 On Mon, May 11, 2009 at 09:17:00AM -0400, Wesley Shields wrote: > On Sun, May 10, 2009 at 09:28:34PM +0000, Marcin Wisnicki wrote: > > On Sun, 10 May 2009 15:22:04 -0400, Glen Barber wrote: > > > > > On Sun, May 10, 2009 at 2:51 PM, Marcin Wisnicki > > > wrote: > > >> They will be installed since they are run dependencies. > > >> > > >>From what I can tell (from several metaports) -- they, themselves, are > > > not installed. The ports defined in the metaport are installed. > > > > That's the point. The metaports should be installed as well (reasons given > > in my original mail). > > > > > There is no source code for, using your example, CUPS[1]. CUPS (in the > > > FreeBSD ports tree) is, for lack of a better explanation, a pointer to > > > which specific ports you need to have in order to get a fully operation > > > CUPS system running. Looking at the Makefile for print/cups [2] you can > > > see the dependencies and that CUPS is not actually built (which in > > > definition is what makes this a metaport). > > > > I know this. > > > > The proper way to make a metaport is to: > > 1. use only RUN_DEPENDS > > 2. set NO_BUILD > > 3. do *NOT* set NO_INSTALL > > 4. provide empty do-install target > > > > There are several metaports that get it right, like for example x11/gnome2: > > > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11/gnome2/Makefile?rev=1.155 > > Based upon your description I think this is a bug in the CUPS port. I'd > suggest you file a PR so that it can be tracked and (hopefully) > addressed. > FWIW, the following gives not so many hits: /usr/ports> grep -R NO_INSTALL * | grep -v NO_INSTALL_MANPAGES Mk/bsd.port.mk:# NO_INSTALL - Use a dummy (do-nothing) install target. Mk/bsd.port.mk:.if defined(NO_INSTALL) && !target(install) Tools/scripts/mkptools/mkpextr: $cap{"NO_INSTALL"} = "YES"; devel/gnustep/Makefile:NO_INSTALL= yes graphics/backfract/Makefile:NO_INSTALL_MANPAGE= yes misc/posixtestsuite/Makefile:NO_INSTALL= YES misc/kde4-l10n/Makefile:NO_INSTALL= yes ports-mgmt/portmk/Mk/bsd.port.mk:# NO_INSTALL - Use a dummy (do-nothing) install target. ports-mgmt/portmk/Mk/bsd.port.mk:.if defined(NO_INSTALL) && !target(install) print/cups/Makefile:NO_INSTALL= yes x11/etoile/Makefile:NO_INSTALL= yes x11/gnustep-app/Makefile:NO_INSTALL= yes Ruling out *.mk scipts there is only 1 port that uses NO_INTSTALL correctly: misc/posixtestsuite These should be fixed (well, I'm not 100% sure): devel/gnustep misc/kde4-l10n print/cups x11/etoile x11/gnustep-app Not so many too :) My 0.02$, Alexey.