From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 27 07:40:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27017106566B for ; Wed, 27 May 2009 07:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 025BB8FC2D for ; Wed, 27 May 2009 07:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4R7e1TM061905 for ; Wed, 27 May 2009 07:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4R7e14U061904; Wed, 27 May 2009 07:40:01 GMT (envelope-from gnats) Resent-Date: Wed, 27 May 2009 07:40:01 GMT Resent-Message-Id: <200905270740.n4R7e14U061904@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, David Naylor Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A81BB1065694 for ; Wed, 27 May 2009 07:35:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 963BC8FC19 for ; Wed, 27 May 2009 07:35:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4R7ZF2I084722 for ; Wed, 27 May 2009 07:35:15 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n4R7ZFc2084721; Wed, 27 May 2009 07:35:15 GMT (envelope-from nobody) Message-Id: <200905270735.n4R7ZFc2084721@www.freebsd.org> Date: Wed, 27 May 2009 07:35:15 GMT From: David Naylor To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/134977: [port/Mk] Expose MAKE_JOBS_NUMBER for MAKE_JOBS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2009 07:40:02 -0000 >Number: 134977 >Category: ports >Synopsis: [port/Mk] Expose MAKE_JOBS_NUMBER for MAKE_JOBS >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed May 27 07:40:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: David Naylor >Release: FreeBSD 7.1 >Organization: Private >Environment: FreeBSD dragon.dg 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #0: Sun Feb 1 20:27:42 SAST 2009 root@dragon.dg:/tmp/tmp/src/sys/GENERIC i386 >Description: Currently if a port needs to pass custom flags to implement concurrency it has to do ${_MAKE_JOBS:C/-j//}. This results in a port needing knowledge and use of bsd.*.mk internals. >How-To-Repeat: n/a >Fix: The patch changes MAKE_JOBS_NUMBER from a user definable to a user tweakable (thus it is always available when MAKE_JOBS_SAFE is defined) and exposes a way for ports to get the number of concurrent builds requested. It *should* have no functional change for existing ports (`find /usr/ports -name Makefile | xargs grep MAKE_JOBS_NUMBER` reveals nothing and _MAKE_JOBS expands to the same value). Patch attached with submission follows: --- /usr/ports/Mk/bsd.port.mk 2009-05-23 13:20:58.000000000 +0200 +++ ports/Mk/bsd.port.mk 2009-05-27 08:38:44.000000000 +0200 @@ -2185,11 +2185,8 @@ _MAKE_JOBS= # .else .if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS) -.if defined(MAKE_JOBS_NUMBER) +MAKE_JOBS_NUMBER?= `${SYSCTL} -n kern.smp.cpus` _MAKE_JOBS= -j${MAKE_JOBS_NUMBER} -.else -_MAKE_JOBS= -j`${SYSCTL} -n kern.smp.cpus` -.endif .if defined(FORCE_MAKE_JOBS) BUILD_FAIL_MESSAGE+= "You have chosen to use multiple make jobs (parallelization) for all ports. This port was not tested for this setting. Please remove FORCE_MAKE_JOBS and retry the build before reporting the failure to the maintainer." .endif >Release-Note: >Audit-Trail: >Unformatted: