From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 09:35:54 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 55B6316A4CE; Tue, 22 Jun 2004 09:35:54 +0000 (GMT)
Received: from relay.macomnet.ru (relay.macomnet.ru [195.128.64.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A37C243D1D; Tue, 22 Jun 2004 09:35:53 +0000 (GMT)
	(envelope-from maxim@macomnet.ru)
Received: from mp2.macomnet.net (q4n26rvr@mp2.macomnet.net [195.128.64.6])
	by relay.macomnet.ru (8.12.10/8.12.10) with ESMTP id i5M9ZIu517026503;
	Tue, 22 Jun 2004 13:35:18 +0400 (MSD)
Date: Tue, 22 Jun 2004 13:35:18 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Luigi Rizzo <rizzo@icir.org>
In-Reply-To: <20040622020620.A16578@xorpc.icir.org>
Message-ID: <20040622133000.T6489@mp2.macomnet.net>
References: <40D754D5.1070805@freebsd.org>
	<20040622115532.W5744@mp2.macomnet.net>
	<20040622020620.A16578@xorpc.icir.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
cc: freebsd-current@freebsd.org
cc: Andre Oppermann <andre@freebsd.org>
Subject: Re: New preview patch for ipfw to pfil_hooks conversion
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 09:35:54 -0000

On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote:

> On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote:
> ...
> > > Consider this a FYI.  It is very much a WIP at the moment.  I want
> > > to get this into the tree in before 5.3 code freeze.
> >
> > In fact, our real world tests shown the current -CURRENT comparing to
> > RELENG_5_2 is in a very bad shape.  Is it really worth to commit that
> > mostly cleanup code before say 6-CURRENT with a chance to
>
> of course it is! i also do not follow the reasoning -- given that it is
> cleaning up code, it is only welcome at any stage except perhaps
> in code freeze.

My concern is bugs.  Especially in cleanup code, especially in
ip_pcbopt and ip_reass.

> plus, is the 'bad shape' related at all to what andre posted ?

'bad shape' is related to 5-CURRENT we are trying to make -STABLE.

-- 
Maxim Konovalov