From owner-p4-projects@FreeBSD.ORG  Fri Jul 24 14:51:58 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 022221065677; Fri, 24 Jul 2009 14:51:58 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5148106564A;
	Fri, 24 Jul 2009 14:51:57 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 87B668FC08;
	Fri, 24 Jul 2009 14:51:57 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 40A2D46B90;
	Fri, 24 Jul 2009 10:51:57 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id 51BFA8A0A3;
	Fri, 24 Jul 2009 10:51:56 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Jonathan Anderson <jona@freebsd.org>
Date: Fri, 24 Jul 2009 09:43:08 -0400
User-Agent: KMail/1.9.7
References: <200907230537.n6N5bfaM064484@repoman.freebsd.org>
In-Reply-To: <200907230537.n6N5bfaM064484@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907240943.08676.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Fri, 24 Jul 2009 10:51:56 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 166430 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2009 14:51:58 -0000

On Thursday 23 July 2009 1:37:41 am Jonathan Anderson wrote:
> http://perforce.freebsd.org/chv.cgi?CH=166430
> 
> Change 166430 by jona@jona-trustedbsd-belle-vmware on 2009/07/23 05:36:50
> 
> 	mmap() can fail and return MAP_FAILED, not just NULL\!

MAP_FAILED is actually the only invalid pointer it will return.  This should 
probably not be checking for NULL.

-- 
John Baldwin