From owner-freebsd-stable@freebsd.org  Sun Sep  4 17:15:07 2016
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10D2AA9DFF4
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Sun,  4 Sep 2016 17:15:07 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id EF99336B
 for <freebsd-stable@freebsd.org>; Sun,  4 Sep 2016 17:15:06 +0000 (UTC)
 (envelope-from avg@FreeBSD.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id EEFA9A9DFF3; Sun,  4 Sep 2016 17:15:06 +0000 (UTC)
Delivered-To: stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEA00A9DFF2
 for <stable@mailman.ysv.freebsd.org>; Sun,  4 Sep 2016 17:15:06 +0000 (UTC)
 (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 54A9D36A
 for <stable@FreeBSD.org>; Sun,  4 Sep 2016 17:15:05 +0000 (UTC)
 (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA17702;
 Sun, 04 Sep 2016 20:15:04 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1bgb0Z-000J5X-Em; Sun, 04 Sep 2016 20:15:03 +0300
Subject: Re: X2APIC support
To: Konstantin Belousov <kostikbel@gmail.com>
References: <20151212130615.GE70867@zxy.spb.ru>
 <20151212133513.GL82577@kib.kiev.ua> <20160901112724.GX88122@zxy.spb.ru>
 <20160901114500.GJ83214@kib.kiev.ua> <20160901121300.GZ88122@zxy.spb.ru>
 <4ba05c00-f737-f562-553d-a7fa59145768@FreeBSD.org>
 <20160904151415.GE83214@kib.kiev.ua>
 <f727b18d-6061-fbaf-6afc-1ae66f8cce16@FreeBSD.org>
 <20160904162926.GF83214@kib.kiev.ua>
Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, stable@FreeBSD.org
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <358ed414-9da6-ac29-55fc-6d7be680c2ce@FreeBSD.org>
Date: Sun, 4 Sep 2016 20:14:07 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160904162926.GF83214@kib.kiev.ua>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Sep 2016 17:15:07 -0000

On 04/09/2016 19:29, Konstantin Belousov wrote:
> This is possible, of course.  But it would not affect "SMP: Added CPU ..."
> lines.

Well, looking at the code it seems that only if mptable is used, then those
lines are expected to correctly identify a BSP.  With MADT there is no
information to identify the BSP and that is supposed to happen in cpu_mp_start().


static void
madt_add_cpu(u_int acpi_id, u_int apic_id, u_int flags)
{
        struct lapic_info *la;

        /*
         * The MADT does not include a BSP flag, so we have to let the
         * MP code figure out which CPU is the BSP on its own.
         */
...

In other words, those "SMP: Added CPU ..." are truly a cosmetic issue.
And it's my guess (just a guess) that BSP LAPIC ID is incorrect in the
problematic configuration.

-- 
Andriy Gapon