From owner-cvs-all Wed Feb 7 16:33:15 2001 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id BF32837B4EC; Wed, 7 Feb 2001 16:32:51 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f180WpQ08947; Wed, 7 Feb 2001 16:32:51 -0800 (PST) Date: Wed, 7 Feb 2001 16:32:51 -0800 From: Alfred Perlstein To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <20010207163251.Z26076@fw.wintelcom.net> References: <200102080027.f180Rg547359@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102080027.f180Rg547359@freefall.freebsd.org>; from jhb@FreeBSD.org on Wed, Feb 07, 2001 at 04:27:41PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010207 16:28] wrote: > jhb 2001/02/07 16:27:41 PST > > Modified files: > sys/kern uipc_mbuf.c > Log: > Don't bother with acquiring/releasing Giant around kmem_malloc() and > kmem_free() for now. Kmem_malloc() and kmem_free() now have appropriate > assertions in place, and these checks aren't feasible until more of the > networking code is locked down. Also, the extra assertions here should > already be caught by the WITNESS code as lock order violations should > mutex operations on Giant be reintroduced here later. I think this is wrong. If the drivers unwound Giant on entry before aquiring the driver lock they would be mpsafe. Unless the vm system is made safe making the network stack safe will have nothing to do with this. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message