From owner-cvs-all@FreeBSD.ORG Mon Dec 13 19:19:54 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EF1016A4D9; Mon, 13 Dec 2004 19:19:54 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4770A43D39; Mon, 13 Dec 2004 19:19:53 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBDJJq6K039345; Mon, 13 Dec 2004 21:19:52 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 88277-14; Mon, 13 Dec 2004 21:19:51 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBDJJo0U039342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 13 Dec 2004 21:19:51 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iBDJJqJd054404; Mon, 13 Dec 2004 21:19:52 +0200 (EET) (envelope-from ru) Date: Mon, 13 Dec 2004 21:19:51 +0200 From: Ruslan Ermilov To: Poul-Henning Kamp Message-ID: <20041213191951.GA54360@ip.net.ua> References: <20041213113310.GB51149@ip.net.ua> <37124.1102943186@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <37124.1102943186@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2004 19:19:54 -0000 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 13, 2004 at 02:06:26PM +0100, Poul-Henning Kamp wrote: > In message <20041213113310.GB51149@ip.net.ua>, Ruslan Ermilov writes: >=20 > >Another issue: > > > >- boot without a diskette in the drive > >- insert a diskette #1 into the drive > >- newfs_msdos it > >- mount_msdosfs it > >- copy some files onto it > >- unmount it > >- insert another (possibly unformatted) diskette #2 > >- mount_msdosfs it and find it somehow succeeds > >- list the contents of the diskette and find that it's identical > > to the contents of diskette #1, including MD5 checksums of > > all files > > > >This smells like a bufcache issue, but I may be wrong about it. >=20 > Sounds like the same thing. >=20 > Can you try this: >=20 > =3D=3D=3D=3D //depot/user/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c= #45 - /bang/p4/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c =3D=3D=3D=3D > @@ -719,6 +719,7 @@ > error_exit: > if (bp) > brelse(bp); > + vinvalbuf(devvp, V_SAVE, NOCRED, td, 0, 0); > if (cp !=3D NULL) { > DROP_GIANT(); > g_topology_lock(); >=20 Doesn't help. Boot with an MS-DOS formatted floppy, mount and unmount it, then: Script started on Mon Dec 13 21:15:42 2004 hammer# dd if=3D/dev/fd0 |hd 00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |..............= =2E.| * 2880+0 records in 2880+0 records out 1474560 bytes transferred in 47.905143 secs (30781 bytes/sec) 00168000 hammer# mount_msdosfs /dev/fd0 /mnt hammer# ll /mnt total 0 -rwxr-xr-x 1 root wheel 0 Dec 13 21:02 foo hammer# umount /mnt Script done on Mon Dec 13 21:17:08 2004 Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBvetXqRfpzJluFF4RAouhAJ9JDEm+6DiDF8a0ctsSQ4vQfOMtFgCbB82q rvkb0IB6OUVpyrGQLHKW+PM= =M+fr -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--