From owner-freebsd-current@FreeBSD.ORG  Tue Mar 24 19:28:43 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 6A1D61065675;
	Tue, 24 Mar 2009 19:28:42 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Date: Tue, 24 Mar 2009 15:28:30 -0400
User-Agent: KMail/1.6.2
References: <1236802980.00085518.1236789602@10.7.7.3>
	<1237920918.1859.1.camel@balrog.2hip.net>
	<49C92FA6.20608@entel.upc.edu>
In-Reply-To: <49C92FA6.20608@entel.upc.edu>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_iRTyJQEFK+JQZPC"
Message-Id: <200903241528.34902.jkim@FreeBSD.org>
Cc: Gustau Perez <gperez@entel.upc.edu>
Subject: Re: [HEADSUP] amd64 suspend/resume code to be comitted
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2009 19:28:44 -0000


--Boundary-00=_iRTyJQEFK+JQZPC
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Tuesday 24 March 2009 03:08 pm, Gustau Perez wrote:
>    With this model (without X's, just text console) suspending and
> resuming seems to work except the video. I can type thing and send
> them to a file (checked). After resuming, it throws a little of
> text (i can see some debug about suspending and resuming firewire
> and usb) and then video is lost.

Please try the attached patch, which just disables restoring VGA state 
while resuming.

Jung-uk Kim

--Boundary-00=_iRTyJQEFK+JQZPC
Content-Type: text/plain;
  charset="iso-8859-1";
  name="vga_isa.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="vga_isa.diff"

--- sys/isa/vga_isa.c	29 Dec 2007 23:26:59 -0000	1.35
+++ sys/isa/vga_isa.c	24 Mar 2009 19:25:56 -0000
@@ -160,6 +160,7 @@ isavga_attach(device_t dev)
 	return 0;
 }
 
+#if 0
 static int
 isavga_suspend(device_t dev)
 {
@@ -209,6 +210,7 @@ isavga_resume(device_t dev)
 	bus_generic_resume(dev);
 	return 0;
 }
+#endif
 
 #ifdef FB_INSTALL_CDEV
 
@@ -254,8 +256,10 @@ static device_method_t isavga_methods[] 
 	DEVMETHOD(device_identify,	isavga_identify),
 	DEVMETHOD(device_probe,		isavga_probe),
 	DEVMETHOD(device_attach,	isavga_attach),
+#if 0
 	DEVMETHOD(device_suspend,	isavga_suspend),
 	DEVMETHOD(device_resume,	isavga_resume),
+#endif
 
 	DEVMETHOD(bus_print_child,	bus_generic_print_child),
 	{ 0, 0 }

--Boundary-00=_iRTyJQEFK+JQZPC--