From owner-cvs-all Wed Feb 7 16:45:54 2001 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 541BE37B4EC; Wed, 7 Feb 2001 16:45:31 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f180jNx21571; Wed, 7 Feb 2001 16:45:23 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f180j0O15691; Wed, 7 Feb 2001 16:45:00 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010207163251.Z26076@fw.wintelcom.net> Date: Wed, 07 Feb 2001 16:44:59 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 08-Feb-01 Alfred Perlstein wrote: > * John Baldwin [010207 16:28] wrote: >> jhb 2001/02/07 16:27:41 PST >> >> Modified files: >> sys/kern uipc_mbuf.c >> Log: >> Don't bother with acquiring/releasing Giant around kmem_malloc() and >> kmem_free() for now. Kmem_malloc() and kmem_free() now have appropriate >> assertions in place, and these checks aren't feasible until more of the >> networking code is locked down. Also, the extra assertions here should >> already be caught by the WITNESS code as lock order violations should >> mutex operations on Giant be reintroduced here later. > > I think this is wrong. If the drivers unwound Giant on entry before > aquiring the driver lock they would be mpsafe. Unless the vm system > is made safe making the network stack safe will have nothing to do > with this. If the drivers are MP safe and use their own locks, then yes, you can probably push Giant down this far. We aren't at that point yet, so let's wait until we get there. And if we do, probably what will be done instead is to grab Giant in the two functions in question. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message