From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Nov 25 03:10:06 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3427D10656A7 for ; Wed, 25 Nov 2009 03:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E5AC68FC1D for ; Wed, 25 Nov 2009 03:10:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAP3A5Sa024997 for ; Wed, 25 Nov 2009 03:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nAP3A5Sl024996; Wed, 25 Nov 2009 03:10:05 GMT (envelope-from gnats) Resent-Date: Wed, 25 Nov 2009 03:10:05 GMT Resent-Message-Id: <200911250310.nAP3A5Sl024996@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, IPS FreeBSD Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26DEC106568B for ; Wed, 25 Nov 2009 03:00:51 +0000 (UTC) (envelope-from campbell@ips.gov.au) Received: from gatekeeper.ips.gov.au (ns.ips.gov.au [138.24.1.34]) by mx1.freebsd.org (Postfix) with SMTP id AB4AA8FC18 for ; Wed, 25 Nov 2009 03:00:50 +0000 (UTC) Received: from gpo.dmz.ips.gov.au (gpo.dmz.ips.gov.au [138.24.8.4]) by gatekeeper.ips.gov.au (Postfix) with ESMTP id 0044122838; Wed, 25 Nov 2009 14:00:45 +1100 (EST) Received: from localhost (localhost.dmz.ips.gov.au [127.0.0.1]) by gpo.dmz.ips.gov.au (Postfix) with ESMTP id E78687E823; Wed, 25 Nov 2009 14:00:45 +1100 (EST) Received: from gpo.dmz.ips.gov.au ([127.0.0.1]) by localhost (gpo.dmz.ips.gov.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Je-4ks9fU53m; Wed, 25 Nov 2009 14:00:40 +1100 (EST) Received: by qayaq.syd.ips.gov.au (Postfix, from userid 2101) id B10407301C; Wed, 25 Nov 2009 14:00:39 +1100 (EST) Message-Id: <20091125030039.B10407301C@qayaq.syd.ips.gov.au> Date: Wed, 25 Nov 2009 14:00:39 +1100 (EST) From: IPS FreeBSD To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: gpstk@users.sourceforge.net, gpstk@arlut.utexas.edu Subject: ports/140855: Port gpstk: reading dual frequency NovaTel data, buffer overflow X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: IPS FreeBSD List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 03:10:06 -0000 >Number: 140855 >Category: ports >Synopsis: Port gpstk: reading dual frequency NovaTel data, buffer overflow >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Nov 25 03:10:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: IPS IT Services >Release: FreeBSD 9.0-CURRENT i386 >Organization: IPS Radio and Space Services >Environment: System: FreeBSD qayaq 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Fri Oct 9 08:09:41 EST 2009 root@qayaq:/usr/obj/usr/src/sys/CT i386 FreeBSD five 7.2-STABLE FreeBSD 7.2-STABLE #0: Fri Oct 16 12:02:25 EST 2009 root@five:/usr/obj/usr/src/sys/FIVE i386 port astro/gpstk (v1.5) >Description: Reading dual frequency NovaTel OEM4 range data fails when number of SV's >=12 due to insufficient buffer size. ie. Two range records (L1 & L2) are produced for each SV which exceeds buffer allocated for 12 SV >How-To-Repeat: Turn on debug in NovatelData.cpp, recompile and read appropriate data file with novaRINEX. >Fix: Increased size of buffer in NovatelData.hpp Used sizeof and corrected determining if a buffer overrun will occur for OEM2 and OEM4 receivers in NovatelData.cpp. Patch files attached. This patch should also work with gpstk v1.6 >Release-Note: >Audit-Trail: >Unformatted: