From owner-freebsd-ports@FreeBSD.ORG Thu Feb 26 13:22:05 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90EF816A4CE for ; Thu, 26 Feb 2004 13:22:05 -0800 (PST) Received: from rdsnet.ro (unknown [62.231.74.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7932643D3F for ; Thu, 26 Feb 2004 13:22:03 -0800 (PST) (envelope-from itetcu@apropo.ro) Received: (qmail 808 invoked from network); 26 Feb 2004 21:22:01 -0000 Received: from unknown (HELO it.buh.cameradicommercio.ro) (81.196.25.19) by mail.rdsnet.ro with SMTP; 26 Feb 2004 21:22:01 -0000 Received: from it.buh.cameradicommercio.ro (localhost.buh.cameradicommercio.ro [127.0.0.1]) by it.buh.cameradicommercio.ro (Postfix) with SMTP id 0509A1A7 for ; Thu, 26 Feb 2004 23:23:58 +0200 (EET) Date: Thu, 26 Feb 2004 23:23:58 +0200 From: Ion-Mihai Tetcu To: ports@FreeBSD.ORG Message-Id: <20040226232358.71a31aa5@it.buh.cameradicommercio.ro> X-Mailer: Sylpheed version 0.9.9claws (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: one or more patch files / optional patch ? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2004 21:22:05 -0000 Hi, The Porters Handbook says "To make fixes and upgrades easier, you should avoid having more than one patch fix the same file"; I'm in the reverse situation, e.g. I have to patch 4 files for adding a feature to a port. It will only make sense to patch all the files or none. Should the patch be split in 4 files or not ? I also want to use OPTIONS to allow the user to choose if he wants this feature or not. How can I integrate this with patch target (e.g. having the patch in files/ but only applied if WITH_ is set) ? -- IOnut Unregistered ;) FreeBSD user