From owner-cvs-src@FreeBSD.ORG Fri Mar 3 02:52:58 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A23416A420; Fri, 3 Mar 2006 02:52:58 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.192.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65D3343D45; Fri, 3 Mar 2006 02:52:57 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-24-147-19-185.hsd1.ma.comcast.net[24.147.19.185](misconfigured sender)) by comcast.net (rwcrmhc13) with ESMTP id <20060303025256m13002eltoe>; Fri, 3 Mar 2006 02:52:56 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id k232quvG006862; Thu, 2 Mar 2006 21:52:56 -0500 (EST) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id k232qu7B006861; Thu, 2 Mar 2006 21:52:56 -0500 (EST) (envelope-from rodrigc) Date: Thu, 2 Mar 2006 21:52:55 -0500 From: Craig Rodrigues To: Giorgos Keramidas Message-ID: <20060303025255.GA6845@crodrigues.org> References: <200603030246.k232kFuh095400@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603030246.k232kFuh095400@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2006 02:52:58 -0000 On Fri, Mar 03, 2006 at 02:46:15AM +0000, Giorgos Keramidas wrote: > keramida 2006-03-03 02:46:15 UTC > > FreeBSD src repository (doc committer) > > Modified files: > sbin/mount mount.c > Log: > When there are no mount options, an implicit "rw" should be printed in > the output of ``mount -p''. > > Approved by: rodrigc Just as additional background, the putfsent() in mount.c which displays an fstab via mount -p is lacking in one serious way... it only converts the numeric mount flags to strings. It is possible to specify mount options in /etc/fstab, or via mount -o which are strings that are passed down into the kernel via nmount(). These strings *may* or *may not* be converted to numerical mount flags, and maybe be stored in the kernel as strings, depending on the filesystem. This makes filesystem mount option parsing such a pain. -- Craig Rodrigues rodrigc@crodrigues.org