From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 18 23:30:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 03A02106566B for ; Mon, 18 Jun 2012 23:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CCB078FC18 for ; Mon, 18 Jun 2012 23:30:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5INUB6D015000 for ; Mon, 18 Jun 2012 23:30:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5INUBvU014996; Mon, 18 Jun 2012 23:30:11 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jun 2012 23:30:11 GMT Resent-Message-Id: <201206182330.q5INUBvU014996@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18088106566B; Mon, 18 Jun 2012 23:21:21 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id EB5EC8FC12; Mon, 18 Jun 2012 23:21:20 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id E3B5D6FD9F3; Mon, 18 Jun 2012 16:21:20 -0700 (PDT) Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xkRV0ll5YkRD; Mon, 18 Jun 2012 16:21:20 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id BB7766FD9F1; Mon, 18 Jun 2012 16:21:20 -0700 (PDT) Received: (nullmailer pid 60132 invoked by uid 1001); Mon, 18 Jun 2012 23:19:46 -0000 Message-Id: <1340061586.795486.60126.nullmailer@experts-exchange.com> Date: Mon, 18 Jun 2012 16:19:46 -0700 From: Jason Helfman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: kuriyama@FreeBSD.org Subject: ports/169213: [PATCH] emulators/virtio-kmod: fix usage of ${SRC_BASE} before it is defined X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 23:30:12 -0000 >Number: 169213 >Category: ports >Synopsis: [PATCH] emulators/virtio-kmod: fix usage of ${SRC_BASE} before it is defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jun 18 23:30:11 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 8.3-RELEASE amd64 >Organization: >Environment: System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC >Description: Original PR filed as ports/165994 SRC_BASE is being used before being defined in several ports. it happened to work anyways in most cases because the main use of SRC_BASE is for checking if ${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/. Port maintainer (kuriyama@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- virtio-kmod-0.234349.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/emulators/virtio-kmod/Makefile,v retrieving revision 1.4 diff -u -r1.4 Makefile --- Makefile 22 Apr 2012 13:52:23 -0000 1.4 +++ Makefile 18 Jun 2012 23:20:43 -0000 @@ -24,12 +24,12 @@ NEEDSUBDIRS= amd64 conf contrib dev/pci geom i386 kern net netinet netinet6 \ sys tools vm x86 +.include + .if !exists(${SRC_BASE}/sys/Makefile) IGNORE= requires kernel source to be installed .endif -.include - .if ${OSREL} != "8.2" && ${OSREL} != "8.3" && ${OSREL} != "9.0" IGNORE= not supported $${OSREL} (${OSREL}) .endif --- virtio-kmod-0.234349.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: