From owner-svn-src-all@FreeBSD.ORG  Thu Oct 20 07:21:29 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C69B1065674;
	Thu, 20 Oct 2011 07:21:29 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EDB38FC18;
	Thu, 20 Oct 2011 07:21:28 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA12854;
	Thu, 20 Oct 2011 10:21:26 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1RGmwQ-000JGl-Gb; Thu, 20 Oct 2011 10:21:26 +0300
Message-ID: <4E9FCBF5.1090000@FreeBSD.org>
Date: Thu, 20 Oct 2011 10:21:25 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:7.0.1) Gecko/20111002 Thunderbird/7.0.1
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <201110192344.p9JNicuo047731@svn.freebsd.org>
In-Reply-To: <201110192344.p9JNicuo047731@svn.freebsd.org>
X-Enigmail-Version: undefined
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r226553 - in head/sys: boot/zfs cddl/boot/zfs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Oct 2011 07:21:29 -0000

on 20/10/2011 02:44 Pawel Jakub Dawidek said the following:
> Author: pjd
> Date: Wed Oct 19 23:44:38 2011
> New Revision: 226553
> URL: http://svn.freebsd.org/changeset/base/226553
> 
> Log:
>   Always pass data size for checksum verification function, as using
>   physical block size declared in bp may not always be what we want.
>   For example in case of gang block header physical block size declared
>   in bp is much larger than SPA_GANGBLOCKSIZE (512 bytes) and checksum
>   calculation failed. This bug could lead to accessing unallocated
>   memory and resets/failures during boot.
>   
>   MFC after:	3 days

I believe that this change is going in the wrong direction.  I'd rather prefer
that we decreased number of parameters :-)  Se my other email.

Besides I do not see where we currently really verify checksum of a re-assembled
gang block.

-- 
Andriy Gapon