From owner-svn-src-all@FreeBSD.ORG  Sun Dec 22 12:10:36 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D70384CA;
 Sun, 22 Dec 2013 12:10:36 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C38411863;
 Sun, 22 Dec 2013 12:10:36 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rBMCAavm034004;
 Sun, 22 Dec 2013 12:10:36 GMT (envelope-from glebius@svn.freebsd.org)
Received: (from glebius@localhost)
 by svn.freebsd.org (8.14.7/8.14.7/Submit) id rBMCAa04034003;
 Sun, 22 Dec 2013 12:10:36 GMT (envelope-from glebius@svn.freebsd.org)
Message-Id: <201312221210.rBMCAa04034003@svn.freebsd.org>
From: Gleb Smirnoff <glebius@FreeBSD.org>
Date: Sun, 22 Dec 2013 12:10:36 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r259719 - head/sys/netpfil/pf
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Dec 2013 12:10:36 -0000

Author: glebius
Date: Sun Dec 22 12:10:36 2013
New Revision: 259719
URL: http://svnweb.freebsd.org/changeset/base/259719

Log:
  Fix fallout from r258479: in pf_free_src_node() the node must already
  be unlinked.
  
  Reported by:	Konstantin Kukushkin <dark rambler-co.ru>
  Sponsored by:	Nginx, Inc.

Modified:
  head/sys/netpfil/pf/pf.c

Modified: head/sys/netpfil/pf/pf.c
==============================================================================
--- head/sys/netpfil/pf/pf.c	Sun Dec 22 11:41:26 2013	(r259718)
+++ head/sys/netpfil/pf/pf.c	Sun Dec 22 12:10:36 2013	(r259719)
@@ -713,7 +713,6 @@ pf_free_src_node(struct pf_src_node *sn)
 {
 
 	KASSERT(sn->states == 0, ("%s: %p has refs", __func__, sn));
-	LIST_REMOVE(sn, entry);
 	uma_zfree(V_pf_sources_z, sn);
 }