From owner-cvs-src@FreeBSD.ORG Sun May 22 23:45:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 710F316A41C; Sun, 22 May 2005 23:45:15 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 219C343D48; Sun, 22 May 2005 23:45:15 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.90] ([66.127.85.90]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j4MNiwms036987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 May 2005 16:44:58 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <42911980.8020607@errno.com> Date: Sun, 22 May 2005 16:45:04 -0700 From: Sam Leffler Organization: Errno Consulting User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200505221831.j4MIV8lq072154@repoman.freebsd.org> <4290D2ED.6080602@errno.com> <006a01c55f01$46851520$0100a8c0@bigbang> <4291171E.1030307@root.org> In-Reply-To: <4291171E.1030307@root.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Damien Bergamini , src-committers@FreeBSD.org, Damien Bergamini , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ipw if_ipw.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2005 23:45:15 -0000 Nate Lawson wrote: > Damien Bergamini wrote: > >>> Why? A good freebsd commit msg explains why you make a change. >> >> >> >> Basically because the Linux driver does it and because some users >> reported that this fixes issues with ACPI. Remember that I have >> zero documentation for this chipset except the Linux driver itself >> which is very poorly commented. And Intel refuses to answer to >> any technical question regarding the hardware. > > > It's not an ACPI issue. You would have the problem with any > suspend/resume (i.e., APM). > I think he just meant "issues seen when ACPI is enabled". It appears this change originated in one of the Linux ethernet drivers (can't recall) and has been blindly propagated to other drivers because it works. I applied it when certain 5211 parts started to get PCI bus dma abort errors. Disabling retries stopped it but I was never able to get a logic analyzer in place to see exactly what was happening (this was a cardbus card). Sam