From owner-freebsd-bugs@FreeBSD.ORG Sat May 10 10:10:14 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3539137B401 for ; Sat, 10 May 2003 10:10:14 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D022F43FB1 for ; Sat, 10 May 2003 10:10:13 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h4AHADUp040714 for ; Sat, 10 May 2003 10:10:13 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h4AHADBj040713; Sat, 10 May 2003 10:10:13 -0700 (PDT) Date: Sat, 10 May 2003 10:10:13 -0700 (PDT) Message-Id: <200305101710.h4AHADBj040713@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Tor.Egge@cvsup.no.freebsd.org Subject: Re: kern/51964: panic: race condition with realitexpire() called for zombie X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Tor.Egge@cvsup.no.freebsd.org List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 May 2003 17:10:14 -0000 The following reply was made to PR kern/51964; it has been noted by GNATS. From: Tor.Egge@cvsup.no.freebsd.org To: jilles@stack.nl Cc: FreeBSD-gnats-submit@freebsd.org, svdb@stack.nl Subject: Re: kern/51964: panic: race condition with realitexpire() called for zombie Date: Sat, 10 May 2003 17:07:56 GMT The enclosed patch should fix the problem if your source is newer than "2003/05/01 14:16:38 PDT" (the struct proc mutex must be persistent). If callout_pending() is true then callout_reset() has been called. If callout_active() is false then callout_stop() has been called. --------------------------- Index: sys/kern/kern_time.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_time.c,v retrieving revision 1.101 diff -u -r1.101 kern_time.c --- sys/kern/kern_time.c 26 Feb 2003 17:16:38 -0000 1.101 +++ sys/kern/kern_time.c 10 May 2003 16:44:41 -0000 @@ -527,6 +527,12 @@ p = (struct proc *)arg; PROC_LOCK(p); + /* Check for callout being active */ + if (callout_pending(&p->p_itcallout) || + !callout_active(&p->p_itcallout)) { + PROC_UNLOCK(p); + return; + } psignal(p, SIGALRM); if (!timevalisset(&p->p_realtimer.it_interval)) { timevalclear(&p->p_realtimer.it_value); --------------------------- - Tor Egge