From owner-freebsd-ports-bugs@freebsd.org Wed Aug 26 12:38:20 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E321A99AB09 for ; Wed, 26 Aug 2015 12:38:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF129A6D for ; Wed, 26 Aug 2015 12:38:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7QCcJ4a010088 for ; Wed, 26 Aug 2015 12:38:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile Date: Wed, 26 Aug 2015 12:38:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2015 12:38:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202404 --- Comment #21 from Jan Beich --- Comment on attachment 160366 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D160366 v6 > + --disable-radio-v4l2 \ > + --disable-radio-bsdbt848 \ > + --disable-tv \ > + --disable-tv-v4l2 \ > + --disable-tv-bsdbt848 \ > + --disable-v4l2 \ These are trivial to unbreak, see attachment 160375. And radio is disabled by default, anyway. > @@ -270,17 +206,17 @@ pre-everything:: >=20 > post-patch: > .if ${OSVERSION} >=3D 900010 This conditional is always true since 8.x is EOL since 1 August. Remove? > - @${REINPLACE_CMD} -e \ > + ${REINPLACE_CMD} -e \ > - @${REINPLACE_CMD} \ > + ${REINPLACE_CMD} \ [and others, since v4] Both variants are fine. Only INSTALL_* commands or those in *-install targets are required (by portlint) to be echoed. Actually, all examples=20 in Porter's Handbook for REINPLACE_CMD have @ prepended. Unless you feel strongly the change adds unnecessary noise for |svn blame|. > +A52_LIBS=3D -la52 > +ASS_LIBS=3D -lass > +CACA_LIBS=3D -lcaca > +ENCA_LIBS=3D -lenca > +JACK_LIBS=3D -ljack [and many more] Looking at configure it has the following pattern which consistently fails to add -lfoo in --enable-foo case. I think, _foo=3Dauto options are better left with only _CONFIGURE_OFF like before. Knowing which -lfoo to provide is an implementation detail and shouldn't be present in the port's Makefile. echocheck "FOO support" if test "$_foo" =3D auto ; then _foo=3Dno if pkg_config_add foo ; then _foo=3Dyes fi fi if test "$_foo" =3D yes; then def_foo=3D"#define CONFIG_FOO 1" else def_foo=3D"#undef CONFIG_FOO" fi echores "$_foo" mplayer's configure is no better and one such mistake slipped in the port. # multimedia/mplayer/Makefile.options .if ${PORT_OPTIONS:MRTMP} LIB_DEPENDS+=3D librtmp.so:${PORTSDIR}/multimedia/librtmp CONFIGURE_ARGS+=3D --enable-librtmp EXTRA_LIBS+=3D -lrtmp .else CONFIGURE_ARGS+=3D --disable-librtmp .endif should be .if ${PORT_OPTIONS:MRTMP} LIB_DEPENDS+=3D librtmp.so:${PORTSDIR}/multimedia/librtmp .else CONFIGURE_ARGS+=3D --disable-librtmp .endif or (via option helpers) RTMP_LIB_DEPENDS=3D librtmp.so:${PORTSDIR}/multimedia/librtmp RTMP_CONFIGURE_OFF=3D --disable-librtmp In mplayer2 example it'be reverting JACK_LIB_DEPENDS=3D libjack.so:${PORTSDIR}/audio/jack JACK_CONFIGURE_ENABLE=3D jack JACK_LIBS=3D -ljack back to .if ${PORT_OPTIONS:MJACK} LIB_DEPENDS+=3D libjack.so:${PORTSDIR}/audio/jack .else CONFIGURE_ARGS+=3D --disable-jack .endif or (via option helpers) JACK_LIB_DEPENDS=3D libjack.so:${PORTSDIR}/audio/jack JACK_CONFIGURE_OFF=3D --disable-jack > -LIBAV_LIB_DEPENDS=3D libavresample.so:${PORTSDIR}/multimedia/libav > +LIBAV_LIB_DEPENDS=3D libavresample.so:${PORTSDIR}/multimedia/ffmpeg > LIBAV_CONFIGURE_ENABLE=3D libavresample > LIBAV_LIBS=3D -lavresample ffmpeg is integral requirement like in multimedia/mpv. Just copy uppermost LIB_DEPENDS from there and drop LIBAV option. --=20 You are receiving this mail because: You are the assignee for the bug.=