From owner-cvs-all Thu Nov 15 18:11:34 2001 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id CC50F37B405; Thu, 15 Nov 2001 18:11:27 -0800 (PST) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id fAG2AkH14768; Thu, 15 Nov 2001 21:10:46 -0500 (EST) (envelope-from mike) Date: Thu, 15 Nov 2001 21:10:46 -0500 From: Mike Barcroft To: Steve Kargl Cc: Mike Silbersack , Matthew Jacob , "David O'Brien" , Jonathan Lemon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/gx if_gx.c if_gxreg.h if_gxvar.h Message-ID: <20011115211046.D10210@espresso.q9media.com> References: <20011115183430.V70249-100000@achilles.silby.com> <20011115175616.A77299@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011115175616.A77299@troutmask.apl.washington.edu>; from sgk@troutmask.apl.washington.edu on Thu, Nov 15, 2001 at 05:56:16PM -0800 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Steve Kargl writes: > Add '#include "if_wx.h"' to if_wx.c. > > cat > if_wx.h > #error "The wx device has been supereed by the gx device. I was just about to recommend that inclusion of `device wx' generate an error noting its replacement. This matches best with the guidelines that were added to the Committers Guide, since it would be non-noticable to only generate a warning in this case. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message