From owner-freebsd-ports@FreeBSD.ORG Fri Apr 25 13:09:39 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6046FCA3; Fri, 25 Apr 2014 13:09:39 +0000 (UTC) Received: from mk-outboundfilter-1.mail.uk.tiscali.com (mk-outboundfilter-1.mail.uk.tiscali.com [212.74.114.37]) by mx1.freebsd.org (Postfix) with ESMTP id 3EC6E11BE; Fri, 25 Apr 2014 13:09:37 +0000 (UTC) X-Trace: 92403824/mk-outboundfilter-1.mail.uk.tiscali.com/PIPEX/$ON_NET_AUTH_ACCEPTED/pipex-temporary-group/81.170.77.156/None/crees@freebsd.org X-SBRS: None X-RemoteIP: 81.170.77.156 X-IP-MAIL-FROM: crees@freebsd.org X-SMTP-AUTH: bayofrum@uwclub.net X-MUA: OpenWebMail 2.53 X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlYGAH9dWlNRqk2c/2dsb2JhbABZgwaEC74rgw+BDhd0giYBBSMzIxALDgwCBSECAg8qHgYBiFenLqNJF4EpiDqEJQEBTweCb4FKBI9hiSOGRYwYgzI8gTU X-IPAS-Result: AlYGAH9dWlNRqk2c/2dsb2JhbABZgwaEC74rgw+BDhd0giYBBSMzIxALDgwCBSECAg8qHgYBiFenLqNJF4EpiDqEJQEBTweCb4FKBI9hiSOGRYwYgzI8gTU X-IronPort-AV: E=Sophos;i="4.97,927,1389744000"; d="scan'208";a="92403824" X-IP-Direction: OUT Received: from 81-170-77-156.dynamic.dsl.as9105.com (HELO pegasus.bayofrum.net) ([81.170.77.156]) by smtp.pipex.tiscali.co.uk with ESMTP; 25 Apr 2014 14:09:30 +0100 Received: from www.bayofrum.net (localhost [127.0.0.1]) by pegasus.bayofrum.net (Postfix) with ESMTP id 6B6255D22E; Fri, 25 Apr 2014 14:09:22 +0100 (BST) From: "Chris Rees" To: Stefan Esser , Benjamin Podszun , freebsd-ports@freebsd.org Subject: Re: [FIX] Re: FreeBSD Port: security/sshguard-pf Date: Fri, 25 Apr 2014 14:09:22 +0100 Message-Id: <20140425130832.M61972@FreeBSD.org> In-Reply-To: <534BBF89.90802@freebsd.org> References: <53453547.2070307@uni-bielefeld.de> <534BBF89.90802@freebsd.org> X-Mailer: OpenWebMail 2.53 X-OriginatingIP: 81.170.77.156 (crees) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 6B6255D22E.AA6D1 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@freebsd.org X-Spam-Status: No Cc: crees@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2014 13:09:39 -0000 On Mon, 14 Apr 2014 12:59:21 +0200, Stefan Esser wrote > Am 14.04.2014 10:25, schrieb Benjamin Podszun: > > I'd say this is a bug in sshguard: Failing to start shouldn't exit with 0. > > That said, it first and foremost is a bug in the port. > > > > Looking at the rc script and the diff [1] the problem's easy enough: > > ${sshguard_pidfile} is passed as parameter to -i, but isn't set in the > > script/has no default value. Either the related line from the previous > > revision should be revived or the substitution should change to use > > ${pidfile}, which _is_ set. > > The attached diff fixes the problems in the sshguard rc file. I have > replaced occurences of ${name} with "sshguard", in accordance with > newer rc script style conventions. The diff has to be applied within > the files sub-directory of the sshguard port. > > The other problems of this port (see previous mail) are not fixed and > should still be addressed ... Sorry, I thought you'd committed this! Thanks very much for the patch-- the trick with \$ to delay evaluation was more elegant than my plan to stick that line inside _prestart. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.