From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 1 05:50:02 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02B9110656F4 for ; Wed, 1 Sep 2010 05:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D44048FC20 for ; Wed, 1 Sep 2010 05:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o815o1rB032858 for ; Wed, 1 Sep 2010 05:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o815o13Q032857; Wed, 1 Sep 2010 05:50:01 GMT (envelope-from gnats) Resent-Date: Wed, 1 Sep 2010 05:50:01 GMT Resent-Message-Id: <201009010550.o815o13Q032857@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Scot Hetzel Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8906410656BF for ; Wed, 1 Sep 2010 05:40:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 474D38FC08 for ; Wed, 1 Sep 2010 05:40:02 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o815e2eP090068 for ; Wed, 1 Sep 2010 05:40:02 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o815e1H4090062; Wed, 1 Sep 2010 05:40:02 GMT (envelope-from nobody) Message-Id: <201009010540.o815e1H4090062@www.freebsd.org> Date: Wed, 1 Sep 2010 05:40:02 GMT From: Scot Hetzel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/150174: math/blas: Allow Profiled Libraries to be disabled. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2010 05:50:02 -0000 >Number: 150174 >Category: ports >Synopsis: math/blas: Allow Profiled Libraries to be disabled. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Sep 01 05:50:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Scot Hetzel >Release: FreeBSD 9.0-CURRENT >Organization: >Environment: FreeBSD vbox.hetzel.local 9.0-CURRENT FreeBSD 9.0-CURRENT #20 r211958M: Sun Aug 29 05:40:13 UTC 2010 root@vbox.hetzel.local:/usr/obj/usr/src/9x/sys/GENERIC amd64 >Description: If you have a system without profiled libraries installed, the port still wants to install them. >How-To-Repeat: Have a system without profiled libraries installed, and then cd /usr/ports/math/blas ; make install. >Fix: The attached patch changes the port to use OPTIONS frame work to select if profiled libraries should be installed. Patch attached with submission follows: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/math/blas/Makefile,v retrieving revision 1.47 diff -u -r1.47 Makefile --- Makefile 30 Aug 2010 07:26:27 -0000 1.47 +++ Makefile 1 Sep 2010 00:30:04 -0000 @@ -35,11 +35,25 @@ MAKE_ENV+= ${_u}="${LOCALBASE}/bin/${_u:L}" .endfor -.if !(defined(NOPROFILE) || defined(NO_PROFILE) || defined(WITHOUT_PROFILE)) +# If there are no profiled libraries on this system, default to OFF +.if exists(/usr/lib/libc_p.a) +PROFILE_STATUS= ON +.else +PROFILE_STATUS= OFF +.endif + +OPTIONS= PROFILE "Install Profiled Libraries" ${PROFILE_STATUS} + +.include + +.if !defined(WITHOUT_PROFILE) +MAKE_ARGS+= WITH_PROFILE=true PLIST_FILES+= lib/libblas_p.a +.else +MAKE_ARGS+= WITHOUT_PROFILE=true .endif post-patch: @${CP} ${FILESDIR}/makefile.lib ${WRKSRC}/Makefile -.include +.include >Release-Note: >Audit-Trail: >Unformatted: