From owner-freebsd-perl@FreeBSD.ORG  Fri Dec  5 16:42:26 2014
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: freebsd-perl@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8A1B4A6E
 for <freebsd-perl@freebsd.org>; Fri,  5 Dec 2014 16:42:26 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 638A53EB
 for <freebsd-perl@freebsd.org>; Fri,  5 Dec 2014 16:42:26 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 sB5GgQwD075681
 for <freebsd-perl@freebsd.org>; Fri, 5 Dec 2014 16:42:26 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sB5GgQlF075680;
 Fri, 5 Dec 2014 16:42:26 GMT (envelope-from root)
Date: Fri, 5 Dec 2014 16:42:26 +0000
To: freebsd-perl@freebsd.org
From: "bdrewery (Bryan Drewery)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Requested Changes To] D1241: Force linking of
 `libperl.so` with all shared modules.
Message-ID: <86f48d4bc3909e4be8ab37cdd5330a1f@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1241: Force linking of `libperl.so` with all shared modules.
X-Herald-Rules: none, <12>
X-Phabricator-To: <PHID-USER-ycbrujqwoepzdb6clww2>
X-Phabricator-To: <PHID-USER-pznym5tflgcfrujdlflc>
X-Phabricator-To: <PHID-USER-ifuknol6ikbamccwyr3m>
X-Phabricator-To: <PHID-USER-4gh3fvwn4yczjzkae373>
X-Phabricator-To: <PHID-USER-26snrek27a4tph6sxbot>
X-Phabricator-To: <PHID-USER-pjrg7uwimqcazthartyl>
X-Phabricator-To: <PHID-USER-jscv3vubjwm52q6x3yhs>
X-Phabricator-To: <PHID-USER-fkgap3gnec7nihaftcxl>
X-Phabricator-To: <PHID-USER-xp4awsksj2i7uxrs25tm>
X-Phabricator-To: <PHID-USER-l3az7iekkxqgkhepeceq>
X-Phabricator-Cc: <PHID-USER-xp4awsksj2i7uxrs25tm>
X-Phabricator-Cc: <PHID-MLST-c4uw2nxb3vfao3loy77w>
In-Reply-To: <differential-rev-PHID-DREV-pvhbhua3quiufpmedf65-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-pvhbhua3quiufpmedf65-req@FreeBSD.org>
Thread-Index: ZTQ3MDM3YjlhMTY0ZjBhZGEwNjVkZTY4M2FhIFSB4HI=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-cc>, <differential-other>,
 <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl/>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2014 16:42:26 -0000

bdrewery added a subscriber: bdrewery.
bdrewery requested changes to this revision.
bdrewery added a reviewer: bdrewery.
This revision now requires changes to proceed.

INLINE COMMENTS
  Mk/Scripts/qa.sh:220 You'll need to return 1 for this case, but not you can't without refactoring or using a temp file since this is in a subshell/pipe.

REVISION DETAIL
  https://reviews.freebsd.org/D1241

To: mat, jadawin, culot, sunpoet, swills, bapt, miwi, antoine, bdrewery, erwin
Cc: bdrewery, freebsd-perl