From owner-freebsd-stable@FreeBSD.ORG Thu Aug 14 11:00:12 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C2101065677; Thu, 14 Aug 2008 11:00:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id EE4E48FC0C; Thu, 14 Aug 2008 11:00:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtp (Exim 4.63 (FreeBSD)) (envelope-from ) id 1KTaDd-0004Nr-Ln; Thu, 14 Aug 2008 13:38:13 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m7EAcAvJ028764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Aug 2008 13:38:10 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m7EAcAU1076427; Thu, 14 Aug 2008 13:38:10 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m7EAc9J5076426; Thu, 14 Aug 2008 13:38:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 14 Aug 2008 13:38:09 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20080814103809.GK1803@deviant.kiev.zoral.com.ua> References: <200808130022.m7D0MCaK082721@freefall.freebsd.org> <20080813134210.GG1803@deviant.kiev.zoral.com.ua> <200808131548.37571.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="enGqbSaueFq5omEL" Content-Disposition: inline In-Reply-To: <200808131548.37571.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1KTaDd-0004Nr-Ln eaa0e42a1505bc85c3fafe971ace7f4d X-Terabit: YES Cc: amd64@freebsd.org, stable@freebsd.org, freebsd-stable@freebsd.org, peter@freebsd.org Subject: Re: Pending MFC Reminder [cvs commit: src/sys/amd64/amd64 cpu_switch.S genassym.c src/sys/amd64/ia32 ia32_signal.c src/sys/amd64/include pcb.h src/sys/amd64/linux32 linux32_machdep.c] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 11:00:12 -0000 --enGqbSaueFq5omEL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 13, 2008 at 03:48:37PM -0400, John Baldwin wrote: > On Wednesday 13 August 2008 09:42:10 am Kostik Belousov wrote: > > On Wed, Aug 13, 2008 at 12:22:12AM +0000, MFC Notification Service wrot= e: > > > Dear Konstantin Belousov, > > >=20 > > > As you have requested, I would like to notify you that you have > > > committed a change that may be MFC'ed now, as a testing period > > > specified at the time of that commit is over. > > >=20 > > > For reference purposes following is a copy of your original > > > commit message. > > >=20 > > > Regards, > > >=20 > > > Maxim "MFC Reminder" Sobolev > > > P.S. Please contact Maxim Sobolev if you > > > believe that you received this message due to an error. > > >=20 > > > kib 2008-07-30 11:30:55 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/amd64/amd64 cpu_switch.S genassym.c=20 > > > sys/amd64/ia32 ia32_signal.c=20 > > > sys/amd64/include pcb.h=20 > > > sys/amd64/linux32 linux32_machdep.c=20 > > > Log: > > > SVN rev 180992 on 2008-07-30 11:30:55Z by kib > > > =20 > > > Bring back the save/restore of the %ds, %es, %fs and %gs registers = for > > > the 32bit images on amd64. > > > =20 > > > Change the semantic of the PCB_32BIT pcb flag to request the context > > > switch code to operate on the segment registers. Its previous meani= ng > > > of saving or restoring the %gs base offset is assigned to the new > > > PCB_GS32BIT flag. > > > =20 > > > FreeBSD 32bit image activator sets the PCB_32BIT flag, while Linux = 32bit > > > emulation sets PCB_32BIT | PCB_GS32BIT. > > > =20 > > > Reviewed by: peter > > > MFC after: 2 weeks > > > =20 > > > Revision Changes Path > > > 1.162 +29 -18 src/sys/amd64/amd64/cpu_switch.S > > > 1.169 +1 -0 src/sys/amd64/amd64/genassym.c > > > 1.18 +1 -1 src/sys/amd64/ia32/ia32_signal.c > > > 1.65 +1 -0 src/sys/amd64/include/pcb.h > > > 1.47 +1 -1 src/sys/amd64/linux32/linux32_machdep.c > >=20 > > This appeared to be a not quite trivial MFC to perform. The reason for > > complication is that the HEAD code for amd64 context switch was changed, > > in particular by the r177535 by peter@. > >=20 > > The r177535 formally requires r177533 for the definition of the > > TDP_KTHREAD symbol for asm. The definition is needed for optimization > > of the context switch to the "pure kernel thread", introduced in > > r173004 that is not MFCed either, and possibly never be. > >=20 > > I do not want to backport the code to the old context switch, that would > > mean a rewrite from scratch. Instead, I merged the r177535 (optimization > > of context switch by peter@), and commented out corresponding test in > > the cpu_switch.S for the TDP_KTHREAD. > >=20 > > I would be glad to get an opinions on the approach taken, and especially > > for the wider testing on the RELENG_7/amd64. The problem better be > > solved for 7.1. > >=20 > > The patch: > > http://people.freebsd.org/~kib/misc/amd64_ctx.releng_7.4.patch >=20 > FYI, in 6.x and 7.x there is P_KTHREAD in p_flags that is what TDP_KTHREA= D=20 > replaced. Thank you for note. I updated the patch to use P_KTHREAD. http://people.freebsd.org/~kib/misc/amd64_ctx.releng_7.5.patch --enGqbSaueFq5omEL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkikCxEACgkQC3+MBN1Mb4ikqwCfa0Bd1s5TCfwDD49RcriySSfm 2zEAnAttpLx4EQZltMzlr3mHZCrlYuAv =sON8 -----END PGP SIGNATURE----- --enGqbSaueFq5omEL--