From owner-svn-src-all@FreeBSD.ORG Thu Oct 20 11:40:27 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBFA71065674; Thu, 20 Oct 2011 11:40:27 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 894DE8FC0A; Thu, 20 Oct 2011 11:40:26 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA18378; Thu, 20 Oct 2011 14:40:24 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <4EA008A7.7010203@FreeBSD.org> Date: Thu, 20 Oct 2011 14:40:23 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0.1) Gecko/20111003 Thunderbird/7.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201110192340.p9JNebOH047566@svn.freebsd.org> <4E9FCA7D.8010900@FreeBSD.org> <20111020093552.GF1722@garage.freebsd.pl> In-Reply-To: <20111020093552.GF1722@garage.freebsd.pl> X-Enigmail-Version: undefined Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r226552 - head/sys/boot/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2011 11:40:27 -0000 on 20/10/2011 12:35 Pawel Jakub Dawidek said the following: > On Thu, Oct 20, 2011 at 10:15:09AM +0300, Andriy Gapon wrote: >> I believe that this commit is incorrect. >> It does appear to do the right thing for raidz, but I believe that it breaks the >> simple case when v_read is vdev_read_phys. Now because the bp argument is not >> NULL, the latter will try to read BP_GET_PSIZE(bp) bytes instead of >> SPA_GANGBLOCKSIZE bytes. >> >> I believe that my patch that I shared (much) earlier handles this issue >> correctly and integrally: >> http://article.gmane.org/gmane.os.freebsd.devel.file-systems/13130 >> Did you find anything wrong with it? >> If not, then maybe we can get back to discussing it? > > You see. My memory is very short:) and I remembered that you were > working on gang blocks in ZFS boot code, but could find the commit, so I > went ahead with my changes. Those changes still didn't fix one problem > for me. Your patch seems to be much more complete and correct and it > fixes all my problems. > > Please, wait no longer and commit your patch! We have to have this in 9.0. > Unfortunately, at the moment I can only afford to spend at most 1/2 hour a day for FreeBSD (and those go mostly into reading and writing emails) and my development environment is in a little bit of disarray. I will try to find some time, but if you have a chance to review, possibly rework and commit those changes, that would be really great and appreciated. Thank you! -- Andriy Gapon