From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 22 15:10:11 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B84881065670 for ; Thu, 22 Dec 2011 15:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A10EE8FC24 for ; Thu, 22 Dec 2011 15:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBMFAB6J053499 for ; Thu, 22 Dec 2011 15:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBMFABtd053498; Thu, 22 Dec 2011 15:10:11 GMT (envelope-from gnats) Date: Thu, 22 Dec 2011 15:10:11 GMT Message-Id: <201112221510.pBMFABtd053498@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Rainer Hurling Cc: Subject: Re: ports/163367: [maintainer] [patch] sysutils/wmupmon: build error and missing URL X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Rainer Hurling List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 15:10:11 -0000 The following reply was made to PR ports/163367; it has been noted by GNATS. From: Rainer Hurling To: Michael Scheidell Cc: bug-followup@FreeBSD.org Subject: Re: ports/163367: [maintainer] [patch] sysutils/wmupmon: build error and missing URL Date: Thu, 22 Dec 2011 16:04:05 +0100 On 22.12.2011 14:20 (UTC+1), Michael Scheidell wrote: > A warning is usually just a warning, you will see many of these when you > build FreeBSD source. Yes, I am aware of this. Erroneously I misspelled the build warning as build error, sorry for that. > If the patch corrects something in the upstream, maybe you could submit > it to them so they can properly QA it? Hmm, I am afraid, there is no upstream support for years now :-( > If you are willing to approve this update without the patches, I think > they can be committed pretty quickly, but these patches would need some > time to doublecheck it doesn't open a security/buffer/stack problem. It is only src/update_freebsd.c which I changed because of the warning. The patchfile for src/main.c was only renamed from patch-src_main.c to patch-src__main.c (double underscore). I personally can live without the patch of src/update_freebsd.c, so I would be pleased if you would commit it. Thanks for taking this PR up, Rainer