From owner-freebsd-standards@FreeBSD.ORG Fri Jan 24 18:08:57 2014 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 85146874 for ; Fri, 24 Jan 2014 18:08:57 +0000 (UTC) Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu [IPv6:2001:470:8b2d:1e1c:21b:21ff:feb8:d7b0]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 528DB19DD for ; Fri, 24 Jan 2014 18:08:57 +0000 (UTC) Received: from khavrinen.csail.mit.edu (localhost [127.0.0.1]) by khavrinen.csail.mit.edu (8.14.7/8.14.7) with ESMTP id s0OI8t8l007792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL CN=khavrinen.csail.mit.edu issuer=Client+20CA); Fri, 24 Jan 2014 13:08:55 -0500 (EST) (envelope-from wollman@khavrinen.csail.mit.edu) Received: (from wollman@localhost) by khavrinen.csail.mit.edu (8.14.7/8.14.7/Submit) id s0OI8t2G007789; Fri, 24 Jan 2014 13:08:55 -0500 (EST) (envelope-from wollman) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21218.44087.838181.110669@khavrinen.csail.mit.edu> Date: Fri, 24 Jan 2014 13:08:55 -0500 From: Garrett Wollman To: Bryan Drewery Subject: Re: closedir(3) handling NULL In-Reply-To: <20140124165509.GA73838@admin.xzibition.com> References: <20140124014105.GC37334@admin.xzibition.com> <20140124132435.GA90996@stack.nl> <20140124165509.GA73838@admin.xzibition.com> X-Mailer: VM 7.17 under 21.4 (patch 22) "Instant Classic" XEmacs Lucid X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (khavrinen.csail.mit.edu [127.0.0.1]); Fri, 24 Jan 2014 13:08:56 -0500 (EST) Cc: freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 18:08:57 -0000 < said: > I'm not clear where you stand on this. Is EINVAL more proper or EBADF, > or are you against the change all together? If you pass a null pointer to a function that does not expect one, the result is undefined. If the process is not terminated, its state (including errno and any register or memory contents) may be set to any value whatsoever. If it were me, and I for some reason wanted to check this corner case explicitly, I'd use [EFAULT]. -GAWollman