From owner-freebsd-ports@FreeBSD.ORG Fri Apr 25 15:35:43 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B0714214 for ; Fri, 25 Apr 2014 15:35:43 +0000 (UTC) Received: from gilb.zs64.net (gilb.zs64.net [212.12.50.234]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "gilb.zs64.net", Issuer "Cryptonomicore CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F3C01271 for ; Fri, 25 Apr 2014 15:35:43 +0000 (UTC) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 2954C1075B7; Fri, 25 Apr 2014 15:35:33 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: foomatic-rip and foo2zjs From: Stefan Bethke In-Reply-To: Date: Fri, 25 Apr 2014 17:35:32 +0200 Message-Id: References: <338BD4B8-F25A-4CC5-A5FA-451C48BB5A5C@lassitu.de> <535A4E09.5000006@passap.ru> To: Robert Backhaus X-Mailer: Apple Mail (2.1874) Cc: Boris Samorodov , Freebsd_mailinglist_PORTS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2014 15:35:43 -0000 --Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Am 25.04.2014 um 15:20 schrieb Robert Backhaus : > Anyway, here's a backtrace: - but the pointed line, 1200, just looks = wrong -=20 >=20 > int fd =3D mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built = - Yup, that's it. Here's the patch: >=20 > --- foomaticrip.c.orig 2014-04-25 23:16:06.000000000 +1000 > +++ foomaticrip.c 2014-04-25 23:16:47.000000000 +1000 > @@ -1197,7 +1197,7 @@ > debug =3D 1; > =20 > if (debug) { > - int fd =3D mkstemp (LOG_FILE "-XXXXXX.log"); > + int fd =3D mkstemp ("LOG_FILE-XXXXXX.log"); > if (fd !=3D -1) > logh =3D fdopen(fd, "w"); > else Sorry, that patch does=92t look right to me. LOG_FILE should be a define = that get=92s concatenated with the string literal. Since this is = compile-time, I don=92t see how this would lead to a runtime error, = unless LOG_FILE was defined to some unusual value. Stefan --=20 Stefan Bethke Fon +49 151 14070811 --Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJTWoDFAAoJEA/POViuFuLBUb0IAJRH2VMsIngQUDa3JXcNIUSI wFwgNvSOFu3p4I+Pg/wclbV5Nrkbg7LnFzPvqRFX5hV1RweUb/8I87vG1q3tNIG5 Uan5SvhgFQv2Ttyna1HuMFWbaECYI/25DNDfZixSwEl6lmky9LojHdjn8fX47+GA iqVuYwZqCHtok2LErdJT9gCqPoJTSQ3GJiudf6Ldb2YiafajHWjxYzm2g+kz0UTt ktJxvx5qQOpr0vo1NBslx9wo2p5g/Bkj4CrIS9BmscsbpvrBQJY4IqgyEWnh6ozx SOt+vh6aMCAQbWvMV0xOdmqZW+eS/z/HyZbyWYSyi9cACmKzpLXgrRp3QZzFsYE= =dSJs -----END PGP SIGNATURE----- --Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420--