From owner-freebsd-current@FreeBSD.ORG  Tue Feb  1 21:50:44 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 80069106566B;
	Tue,  1 Feb 2011 21:50:44 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
	by mx1.freebsd.org (Postfix) with ESMTP id 1AA228FC08;
	Tue,  1 Feb 2011 21:50:44 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id 3BA933592FF;
	Tue,  1 Feb 2011 22:50:42 +0100 (CET)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id 26B2117512; Tue,  1 Feb 2011 22:50:42 +0100 (CET)
Date: Tue, 1 Feb 2011 22:50:42 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20110201215041.GA4388@stack.nl>
References: <201101312256.p0VMuI6F075840@freebsd-current.sentex.ca>
	<20110131235153.GC1746@garage.freebsd.pl>
	<F3F2991E-A783-451C-95B5-3E5BC2E5772B@mac.com>
	<20110201081844.GA1897@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110201081844.GA1897@garage.freebsd.pl>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: marcel@FreeBSD.org, Marcel Moolenaar <xcllnt@mac.com>, ia64@freebsd.org,
	current@freebsd.org
Subject: Re: [head tinderbox] failure on ia64/ia64
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Feb 2011 21:50:44 -0000

On Tue, Feb 01, 2011 at 09:18:44AM +0100, Pawel Jakub Dawidek wrote:
> Still, I'm more concerned with CMSG_NXTHDR() macro, which from what I
> see might not be fixed by casting arguments.

Yes, without various checks it expands to
  (struct cmsghdr *)((char *)(cmsg) + \
  _ALIGN(((struct cmsghdr *)(cmsg))->cmsg_len))

Although there is no alignment problem (assuming cmsg is properly
aligned and _ALIGN is correct), this violates -Wcast-align. Therefore I
think an intermediate cast to void * would be appropriate here.

-- 
Jilles Tjoelker