From owner-freebsd-ports@FreeBSD.ORG Sat Apr 26 08:20:22 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1E08B71D for ; Sat, 26 Apr 2014 08:20:22 +0000 (UTC) Received: from forward10l.mail.yandex.net (forward10l.mail.yandex.net [IPv6:2a02:6b8:0:1819::a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Certum Level IV CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C702C125C for ; Sat, 26 Apr 2014 08:20:21 +0000 (UTC) Received: from smtp3h.mail.yandex.net (smtp3h.mail.yandex.net [84.201.186.20]) by forward10l.mail.yandex.net (Yandex) with ESMTP id 9976BBA0F71; Sat, 26 Apr 2014 12:20:17 +0400 (MSK) Received: from smtp3h.mail.yandex.net (localhost [127.0.0.1]) by smtp3h.mail.yandex.net (Yandex) with ESMTP id 1425D1B439E1; Sat, 26 Apr 2014 12:20:16 +0400 (MSK) Received: from 78.108.203.86.tel.ru (78.108.203.86.tel.ru [78.108.203.86]) by smtp3h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 3ehCYo2zy2-KGcWqXqu; Sat, 26 Apr 2014 12:20:16 +0400 (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: ed7233a2-ce15-454c-b864-f183e8493d1e Message-ID: <535B6C40.8050006@passap.ru> Date: Sat, 26 Apr 2014 12:20:16 +0400 From: Boris Samorodov Organization: =?UTF-8?B?0JfQkNCeICLQktCQ0KDQoiI=?= User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Robert Backhaus , Stefan Bethke , Freebsd_mailinglist_PORTS Subject: Re: foomatic-rip and foo2zjs References: <338BD4B8-F25A-4CC5-A5FA-451C48BB5A5C@lassitu.de> <535A4E09.5000006@passap.ru> <535A8394.4060507@passap.ru> <85y4ytpdgx.fsf@iznogoud.viz> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Apr 2014 08:20:22 -0000 26.04.2014 02:16, Robert Backhaus пишет: > On 26 April 2014 02:41, Wolfgang Jenkner > wrote: > > On Fri, Apr 25 2014, Boris Samorodov wrote: > > >> Am 25.04.2014 um 15:20 schrieb Robert Backhaus >: > >> > >>> int fd = mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, > built - Yup, that's it. Here's the patch: > > I think the problem is simply that mkstemp(3) requires an argument with > /trailing/ Xs, in accordance with POSIX[1]. So the upstream usage of it > seems to be wrong. > > [1] > http://pubs.opengroup.org/onlinepubs/009695399/functions/mkstemp.html > > Yes, sorry. I got this wrong. > > The fix upstream has been to stop using mkstemp, and switch to using > sprintf directly. > > http://bzr.linuxfoundation.org/loggerhead/openprinting/cups-filters/revision/7196 Thanks to all involved! The patch for foomatic-filters and an update of cups-filters are committed. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve