From owner-cvs-all@FreeBSD.ORG  Fri Nov 16 17:26:22 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5494716A418;
	Fri, 16 Nov 2007 17:26:22 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 00A9F13C4D3;
	Fri, 16 Nov 2007 17:26:21 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lAGHOolW020452;
	Fri, 16 Nov 2007 10:24:51 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 16 Nov 2007 10:24:31 -0700 (MST)
Message-Id: <20071116.102431.-484246174.imp@bsdimp.com>
To: scottl@samsco.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <473DC220.6030809@samsco.org>
References: <200710260859.l9Q8xPdP099307@repoman.freebsd.org>
	<473DC220.6030809@samsco.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org,
	sos@freebsd.org
Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Nov 2007 17:26:22 -0000

In message: <473DC220.6030809@samsco.org>
            Scott Long <scottl@samsco.org> writes:
: SXren Schmidt wrote:
: > sos         2007-10-26 08:59:24 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/dev/ata          atapi-cd.c atapi-cd.h 
: >   Log:
: >   Update the way we get the mode pages on probe.
: >   
: >   Revision  Changes    Path
: >   1.194     +22 -25    src/sys/dev/ata/atapi-cd.c
: >   1.47      +1 -0      src/sys/dev/ata/atapi-cd.h
: 
: Just curious, what was the motivation for changing from doing a
: TUR to doing a MODE_SENSE in g_access?  Your new code now relies
: on what I'd consider is a fairly obscure feature of the SFF-8020i
: spec, and one that contradicts the MMC and SPC specs that are now
: used as the normative references for packet commands.  There's at
: least once case, the virtual CDROM emulator in Parallels, that
: appears not to support this feature, and I'd bet pretty heavily
: that there are a number of real devices that won't support it
: either.

QEMU also has issues.

Warner