From owner-freebsd-current@FreeBSD.ORG Tue Jun 22 11:41:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1D3F16A4CE for ; Tue, 22 Jun 2004 11:41:32 +0000 (GMT) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED3C443D5D for ; Tue, 22 Jun 2004 11:41:31 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 69680 invoked from network); 22 Jun 2004 11:41:30 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 22 Jun 2004 11:41:30 -0000 Message-ID: <40D81AEF.20579AAC@freebsd.org> Date: Tue, 22 Jun 2004 13:41:35 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Ian FREISLICH References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-net@freebsd.org cc: freebsd-current@freebsd.org Subject: Re: New preview patch for ipfw to pfil_hooks conversion X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2004 11:41:32 -0000 Ian FREISLICH wrote: > > Andre Oppermann wrote: > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_input.c and ip_output.c. > > That would be a very a nice thing, but it looks like this breaks > the patch that I submitted (kern/64240) which fixes the acknowledged > problem with 'ipfw tee' accepting packets instead of copying them > to the divert port and then processing the packet according to the > rest of the rule set. Hmmm... I'll have a look at kern/64240. I guess while I'm rewriting this stuff anyway I can fix this too in one go. > There have been about 5 PRs (most with patches) in the past years > which all claim to fix this problem indicating that here is a need > for a fix. We rely on the fix in kern/64240 to collect traffic > accounting information for billing and statistical purposes. There > hasn't been much interest from the committers in having a look at > this even though the work has already been done. Could you give me all PR numbers? That'll make it easier for me get the code in. > Now that you're actively working on that part of the source, would > it be possible to take a look? I would also be happy to create a > new patch to fix this problem against ipfw with pfilhooks if that's > what it's going to take to get a fix committed. It's ok, I don't need new patches against the converted pfil_hooks code. -- Andre