From owner-svn-ports-head@FreeBSD.ORG Tue Sep 25 15:38:47 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D31F2106564A; Tue, 25 Sep 2012 15:38:47 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id D9DF88FC19; Tue, 25 Sep 2012 15:38:46 +0000 (UTC) Received: by eaac10 with SMTP id c10so1056040eaa.13 for ; Tue, 25 Sep 2012 08:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=5BJA8SfspbWFALp/byfsklQWaNhuHJThzUgrYd8keeE=; b=gHz7wTzTh1D/SpA9/GmV5T+h5ahck/mVdaFFSFrS7k93lJVFX0EjaAULWInn3q7KVY r2ZtyndLM9sw3J8I/Efyjw3Qqj30AA0/HTV+69AUrxYRQudw9ZdSHwmxgssJcQy9YCcY 4EtuRCvrIwdnCpSyjVUV5sEEQVLu0gChVywxmVksTPaKKFxt/KU3O4OwQrK9gLlcnaaQ sKU4vvTPJDfzFpRVgLYGV2+K80eEU3idBPxzltbxNxCDxR8uf7HFlq6B0pzrhFZmqQrL 2szUcjigSnrvZfvR5MPthQ48KkaLrOa6vOYgMV1uHhnozWd4eWS73ugN74LTIYMIcQnE 5yDw== MIME-Version: 1.0 Received: by 10.14.180.65 with SMTP id i41mr20956109eem.10.1348587126914; Tue, 25 Sep 2012 08:32:06 -0700 (PDT) Received: by 10.204.10.141 with HTTP; Tue, 25 Sep 2012 08:32:06 -0700 (PDT) Received: by 10.204.10.141 with HTTP; Tue, 25 Sep 2012 08:32:06 -0700 (PDT) In-Reply-To: <201209251523.q8PFNFwb051770@svn.freebsd.org> References: <201209251523.q8PFNFwb051770@svn.freebsd.org> Date: Tue, 25 Sep 2012 16:32:06 +0100 Message-ID: From: Chris Rees To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r304840 - in head/x11: nvidia-driver nvidia-driver-173 nvidia-driver-71 nvidia-driver-96 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 15:38:47 -0000 On 25 Sep 2012 16:23, "Alexey Dokuchaev" wrote: > > Author: danfe > Date: Tue Sep 25 15:23:14 2012 > New Revision: 304840 > URL: http://svn.freebsd.org/changeset/ports/304840 > > Log: > Fix the problem that PKGVERSION for 173.14.xx legacy driver went backwards > when it was updated to .35 on the 12th. That moment, it kept PORTREVISION > 1 from the master port. When the master port was updated and PORTREVISION > removed on the 22nd, PKGVERSION of nvidia-driver-173 went backwards as its > PORTREVISION dropped from 1 to 0. While I am at it, provide a comments in > all makefiles that keeping PORTREVISION setting (even when it is seemingly > zero) is important. > > Reported by: erwin > > Modified: > head/x11/nvidia-driver-173/Makefile > head/x11/nvidia-driver-71/Makefile > head/x11/nvidia-driver-96/Makefile > head/x11/nvidia-driver/Makefile > > Modified: head/x11/nvidia-driver-173/Makefile > ============================================================================== > --- head/x11/nvidia-driver-173/Makefile Tue Sep 25 14:55:49 2012 (r304839) > +++ head/x11/nvidia-driver-173/Makefile Tue Sep 25 15:23:14 2012 (r304840) > @@ -6,6 +6,8 @@ > # > > DISTVERSION= 173.14.35 > +# Explicitly set PORTREVISION as it can be overridden by the master port > +PORTREVISION= 1 I don't know if a special comment is needed; this is pretty standard slave behaviour. However, it is a common problem, perhaps we could put a note into the Porter's Handbook in PORTREVISION or master/slave sections? "It is usually incorrect to set PORTREVISION to 0, except in a slave port where it should override the master port" Hm, how best to put that into docspeak? Chris