From owner-svn-src-all@FreeBSD.ORG  Fri Jan  4 17:21:02 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id CC59EEC2;
 Fri,  4 Jan 2013 17:21:02 +0000 (UTC) (envelope-from john@baldwin.cx)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 8ABD5E6C;
 Fri,  4 Jan 2013 17:21:02 +0000 (UTC)
Received: from ralph.baldwin.cx (c-68-39-198-164.hsd1.de.comcast.net
 [68.39.198.164])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id A634BB93E;
 Fri,  4 Jan 2013 12:21:01 -0500 (EST)
From: John Baldwin <john@baldwin.cx>
To: Jaakko Heinonen <jh@freebsd.org>
Subject: Re: svn commit: r244585 - in head: . sys/geom/label
Date: Fri, 4 Jan 2013 12:18:07 -0500
User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; )
References: <201212221343.qBMDhCHa086834@svn.freebsd.org>
In-Reply-To: <201212221343.qBMDhCHa086834@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201301041218.07804.john@baldwin.cx>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 04 Jan 2013 12:21:01 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2013 17:21:02 -0000

On Saturday, December 22, 2012 08:43:12 AM Jaakko Heinonen wrote:
> Author: jh
> Date: Sat Dec 22 13:43:12 2012
> New Revision: 244585
> URL: http://svnweb.freebsd.org/changeset/base/244585
> 
> Log:
>   Mangle label names containing spaces, non-printable characters '%' or
>   '"'.  Mangling is only done for label names read from file system
>   metadata. Encoding resembles URL encoding. For example, the space
>   character becomes %20.
> 
>   Help by:	kib
>   Discussed with:	imp, kib, pjd

Ouch, mangling spaces seems unfortunate.  I guess fixing the devctl protocol 
is too hard, and/or we can't just encode it at the protocol layer but leave 
the actual device names untouched?  OS X preserves spaces in volume names and 
those can be quite common on ISO images, so mangling them really does seem to 
be a shame if we can avoid it.

-- 
John Baldwin